Remove redundant insert method in serialize #3162

1. 
   sipa commented at 6:42 pm on October 26, 2013: member

   This seems to cause problems on recent clang, and looks totally redundant and unused.

   The const_iterator version is identical to the vector::const_iterator one (which is a typedef thereof). Marking it private (instead of removing) compiles fine, so this version is effectively unused even.

2. Remove redundant insert method in serialize.

   This seems to cause problems on recent clang, and looks totally
   redundant and unused.
   
   The const_iterator version is identical to the vector::const_iterator
   one (which is a typedef thereof). Marking it private (instead of
   removing) compiles fine, so this version is effectively unused even.

   e9755001ab
3. 
   jgarzik commented at 6:45 pm on October 26, 2013: contributor

   ACK
4. 
   sipa commented at 6:45 pm on October 26, 2013: member

   Updated, this will not fix #2806. There is an additional problem with datetime/locale conversion.
5. 
   BitcoinPullTester commented at 6:56 pm on October 26, 2013: none

   Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/e9755001ab1b63d205f1e130ffe42b213cb052c6 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
6. 
   laanwj commented at 3:50 pm on October 28, 2013: member

   ACK
7. laanwj referenced this in commit cde10602a6 on Oct 29, 2013
8. laanwj merged this on Oct 29, 2013
9. laanwj closed this on Oct 29, 2013

   ---

10. freider referenced this in commit aa281aeb32 on Dec 28, 2013
11. BetaCoinDev referenced this in commit c497d5ff5f on Apr 11, 2014
12. BetaCoinDev referenced this in commit 4e342ab683 on Apr 11, 2014
13. NoirX referenced this in commit 2429ee26b6 on Jul 14, 2014
14. Tranz5 referenced this in commit d08447b4e3 on Jul 22, 2014
15. palmd referenced this in commit 237884df1e on Nov 24, 2014
16. zencd referenced this in commit b2697edb58 on Jun 14, 2017
17. iamunick referenced this in commit fc9f5431c0 on Feb 18, 2018
18. iamunick referenced this in commit f0ceca00c5 on Feb 18, 2018
19. Bushstar referenced this in commit 33d04ebf28 on Apr 8, 2020
20. DrahtBot locked this on Sep 8, 2021

Contributors
sipa jgarzik BitcoinPullTester laanwj