. #31688

pull Recepxx34 wants to merge 1 commits into bitcoin:master from Recepxx34:patch-1 changing 2 files +233 −79
  1. Recepxx34 commented at 7:46 am on January 20, 2025: none
      0key=:pubKey&status=:channelStatus
      1
      2Bitcoin Core integration/staging tree
      3=====================================
      4
      5https://bitcoincore.org
      6
      7For an immediately usable, binary version of the Bitcoin Core software, see https://bitcoincore.org/en/download/.
      8
      9What is Bitcoin Core?
     10---------------------
     11
     12Bitcoin Core connects to the Bitcoin peer-to-peer network to download and fully validate blocks and transactions. It also includes a wallet and graphical user interface, which can be optionally built.
     13
     14Further information about Bitcoin Core is available in the [doc folder](/doc).
     15
     16License
     17-------
     18
     19Bitcoin Core is released under the terms of the MIT license. See [COPYING](COPYING) for more information or see https://opensource.org/licenses/MIT.
     20
     21Development Process
     22-------------------
     23
     24The `master` branch is regularly built (see `doc/build-*.md` for instructions) and tested, but it is not guaranteed to be completely stable. [Tags](https://github.com/bitcoin/bitcoin/tags) are created regularly from release branches to indicate new official, stable release versions of Bitcoin Core.
     25
     26The https://github.com/bitcoin-core/gui repository is used exclusively for the development of the GUI. Its master branch is identical in all monotree repositories. Release branches and tags do not exist, so please do not fork that repository unless it is for development reasons.
     27
     28The contribution workflow is described in [CONTRIBUTING.md](CONTRIBUTING.md) and useful hints for developers can be found in [doc/developer-notes.md](doc/developer-notes.md).
     29
     30Testing
     31-------
     32
     33Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.
     34
     35### Automated Testing
     36
     37Developers are strongly encouraged to write [unit tests](src/test/README.md) for new code, and to submit new unit tests for old code. Unit tests can be compiled and run (assuming they weren't disabled during the generation of the build system) with: `ctest`. Further details on running and extending unit tests can be found in [/src/test/README.md](/src/test/README.md).
     38
     39There are also [regression and integration tests](/test), written in Python.
     40These tests can be run (if the [test dependencies](/test) are installed) with: `build/test/functional/test_runner.py` (assuming `build` is your build directory).
     41
     42The CI (Continuous Integration) systems make sure that every pull request is built for Windows, Linux, and macOS, and that unit/sanity tests are run automatically.
     43
     44### Manual Quality Assurance (QA) Testing
     45
     46Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.
     47
     48Translations
     49------------
     50
     51Changes to translations as well as new translations can be submitted to [Bitcoin Core's Transifex page](https://www.transifex.com/bitcoin/bitcoin/).
     52
     53[
     54  {
     55    "status": 1,
     56    "closing_reason": null,
     57    "closing_date": null,
     58    "capacity": 200000000,
     59    "short_id": "855248x2989x1",
     60    "id": "940355120828055553",
     61    "fee_rate": 1,
     62    "node": {
     63      "alias": "yalls.org clearnet-yalls",
     64      "public_key": "0288be11d147e1525f7f234f304b094d6627d2c70f3313d7ba3696887b261c4447",
     65      "channels": 93,
     66      "capacity": "6651565060"
     67    }
     68  },
     69  {
     70    "status": 1,
     71    "closing_reason": null,
     72    "closing_date": null,
     73    "capacity": 150000000,
     74    "short_id": "865606x2919x1",
     75    "id": "951743862263971841",
     76    "fee_rate": 100,
     77    "node": {
     78      "alias": "Megalithic.me",
     79      "public_key": "0322d0e43b3d92d30ed187f4e101a9a9605c3ee5fc9721e6dac3ce3d7732fbb13e",
     80      "channels": 83,
     81      "capacity": "6584980682"
     82    }
     83  },
     84  {
     85    "status": 1,
     86    "closing_reason": null,
     87    "closing_date": null,
     88    "capacity": 150000000,
     89    "short_id": "867452x3629x1",
     90    "id": "953773560775376897",
     91    "fee_rate": 2000,
     92    "node": {
     93      "alias": "cyberdyne.sh",
     94      "public_key": "03a93b87bf9f052b8e862d51ebbac4ce5e97b5f4137563cd5128548d7f5978dda9",
     95      "channels": 196,
     96      "capacity": "8511550562"
     97    }
     98  },
     99  {
    100    "status": 1,
    101    "closing_reason": null,
    102    "closing_date": null,
    103    "capacity": 115000000,
    104    "short_id": "827084x1086x1",
    105    "id": "909388475218657281",
    106    "fee_rate": 1000,
    107    "node": {
    108      "alias": "yalls.org yalls-tor",
    109      "public_key": "03d06758583bb5154774a6eb221b1276c9e82d65bbaceca806d90e20c108f4b1c7",
    110      "channels": 74,
    111      "capacity": "3241046701"
    112    }
    113  },
    114  {
    115    "status": 1,
    116    "closing_reason": null,
    117    "closing_date": null,
    118    "capacity": 100000000,
    119    "short_id": "740620x2091x0",
    120    "id": "814320301900496896",
    121    "fee_rate": 3000,
    122    "node": {
    123      "alias": "okx",
    124      "public_key": "0294ac3e099def03c12a37e30fe5364b1223fd60069869142ef96580c8439c2e0a",
    125      "channels": 612,
    126      "capacity": "73942283559"
    127    }
    128  },
    129  {
    130    "status": 1,
    131    "closing_reason": null,
    132    "closing_date": null,
    133    "capacity": 100000000,
    134    "short_id": "759240x2353x1",
    135    "id": "834793208426856449",
    136    "fee_rate": 2500,
    137    "node": {
    138      "alias": "nicehash-ln1",
    139      "public_key": "037659a0ac8eb3b8d0a720114efc861d3a940382dcfa1403746b4f8f6b2e8810ba",
    140      "channels": 1055,
    141      "capacity": "16787969802"
    142    }
    143  },
    144  {
    145    "status": 1,
    146    "closing_reason": null,
    147    "closing_date": null,
    148    "capacity": 100000000,
    149    "short_id": "810358x1309x6",
    150    "id": "890998043747090438",
    151    "fee_rate": 2000,
    152    "node": {
    153      "alias": "LNBϟG [Edge-4]",
    154      "public_key": "039edc94987c8f3adc28dab455efc00dea876089a120f573bd0b03c40d9d3fb1e1",
    155      "channels": 241,
    156      "capacity": "5095855252"
    157    }
    158  },
    159  {
    160    "status": 1,
    161    "closing_reason": null,
    162    "closing_date": null,
    163    "capacity": 100000000,
    164    "short_id": "822086x2856x1",
    165    "id": "903893116219031553",
    166    "fee_rate": 3000,
    167    "node": {
    168      "alias": "okx",
    169      "public_key": "0294ac3e099def03c12a37e30fe5364b1223fd60069869142ef96580c8439c2e0a",
    170      "channels": 612,
    171      "capacity": "73942283559"
    172    }
    173  },
    174  {
    175    "status": 1,
    176    "closing_reason": null,
    177    "closing_date": null,
    178    "capacity": 100000000,
    179    "short_id": "822104x753x1",
    180    "id": "903912907290509313",
    181    "fee_rate": 3000,
    182    "node": {
    183      "alias": "okx",
    184      "public_key": "0294ac3e099def03c12a37e30fe5364b1223fd60069869142ef96580c8439c2e0a",
    185      "channels": 612,
    186      "capacity": "73942283559"
    187    }
    188  },
    189  {
    190    "status": 1,
    191    "closing_reason": null,
    192    "closing_date": null,
    193    "capacity": 100000000,
    194    "short_id": "843151x2151x0",
    195    "id": "927054328611930112",
    196    "fee_rate": 2000,
    197    "node": {
    198      "alias": "Binance",
    199      "public_key": "03a1f3afd646d77bdaf545cceaf079bab6057eae52c6319b63b5803d0989d6a72f",
    200      "channels": 211,
    201      "capacity": "67249400000"
    202    }
    203  }
    204]
    205
    206
    207Translations are periodically pulled from Transifex and merged into the git repository. See the [translation process](doc/translation_process.md) for details on how this works.
    208
    209**Important**: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.
    210
    211<!--
    212*** Please remove the following help text before submitting: ***
    213
    214Pull requests without a rationale and clear improvement may be closed
    215immediately.
    216
    217GUI-related pull requests should be opened against
    218https://github.com/bitcoin-core/gui
    219first. See CONTRIBUTING.md
    220-->
    221
    222<!--
    223Please provide clear motivation for your patch and explain how it improves
    224Bitcoin Core user experience or Bitcoin Core developer experience
    225significantly:
    226
    227* Any test improvements or new tests that improve coverage are always welcome.
    228* All other changes should have accompanying unit tests (see `src/test/`) or
    229  functional tests (see `test/`). Contributors should note which tests cover
    230  modified code. If no tests exist for a region of modified code, new tests
    231  should accompany the change.
    232* Bug fixes are most welcome when they come with steps to reproduce or an
    233  explanation of the potential issue as well as reasoning for the way the bug
    234  was fixed.
    235* Features are welcome, but might be rejected due to design or scope issues.
    236  If a feature is based on a lot of dependencies, contributors should first
    237  consider building the system outside of Bitcoin Core, if possible.
    238* Refactoring changes are only accepted if they are required for a feature or
    239  bug fix or otherwise improve developer experience significantly. For example,
    240  most "code style" refactoring changes require a thorough explanation why they
    241  are useful, what downsides they have and why they *significantly* improve
    242  developer experience or avoid serious programming bugs. Note that code style
    243  is often a subjective matter. Unless they are explicitly mentioned to be
    244  preferred in the [developer notes](/doc/developer-notes.md), stylistic code
    245  changes are usually rejected.
    246-->
    247
    248<!--
    249Bitcoin Core has a thorough review process and even the most trivial change
    250needs to pass a lot of eyes and requires non-zero or even substantial time
    251effort to review. There is a huge lack of active reviewers on the project, so
    252patches often sit for a long time.
    253-->
    
  2. Update and rename README.md to GET /api/v1/lightning/channels?public_key=:pubKey&status=:channelStatus
    Bitcoin Core integration/staging tree
    =====================================
    
    https://bitcoincore.org
    
    For an immediately usable, binary version of the Bitcoin Core software, see
    https://bitcoincore.org/en/download/.
    
    What is Bitcoin Core?
    ---------------------
    
    Bitcoin Core connects to the Bitcoin peer-to-peer network to download and fully
    validate blocks and transactions. It also includes a wallet and graphical user
    interface, which can be optionally built.
    
    Further information about Bitcoin Core is available in the [doc folder](/doc).
    
    License
    -------
    
    Bitcoin Core is released under the terms of the MIT license. See [COPYING](COPYING) for more
    information or see https://opensource.org/licenses/MIT.
    
    Development Process
    -------------------
    
    The `master` branch is regularly built (see `doc/build-*.md` for instructions) and tested, but it is not guaranteed to be
    completely stable. [Tags](https://github.com/bitcoin/bitcoin/tags) are created
    regularly from release branches to indicate new official, stable release versions of Bitcoin Core.
    
    The https://github.com/bitcoin-core/gui repository is used exclusively for the
    development of the GUI. Its master branch is identical in all monotree
    repositories. Release branches and tags do not exist, so please do not fork
    that repository unless it is for development reasons.
    
    The contribution workflow is described in [CONTRIBUTING.md](CONTRIBUTING.md)
    and useful hints for developers can be found in [doc/developer-notes.md](doc/developer-notes.md).
    
    Testing
    -------
    
    Testing and code review is the bottleneck for development; we get more pull
    requests than we can review and test on short notice. Please be patient and help out by testing
    other people's pull requests, and remember this is a security-critical project where any mistake might cost people
    lots of money.
    
    ### Automated Testing
    
    Developers are strongly encouraged to write [unit tests](src/test/README.md) for new code, and to
    submit new unit tests for old code. Unit tests can be compiled and run
    (assuming they weren't disabled during the generation of the build system) with: `ctest`. Further details on running
    and extending unit tests can be found in [/src/test/README.md](/src/test/README.md).
    
    There are also [regression and integration tests](/test), written
    in Python.
    These tests can be run (if the [test dependencies](/test) are installed) with: `build/test/functional/test_runner.py`
    (assuming `build` is your build directory).
    
    The CI (Continuous Integration) systems make sure that every pull request is built for Windows, Linux, and macOS,
    and that unit/sanity tests are run automatically.
    
    ### Manual Quality Assurance (QA) Testing
    
    Changes should be tested by somebody other than the developer who wrote the
    code. This is especially important for large or high-risk changes. It is useful
    to add a test plan to the pull request description if testing the changes is
    not straightforward.
    
    Translations
    ------------
    
    Changes to translations as well as new translations can be submitted to
    [Bitcoin Core's Transifex page](https://www.transifex.com/bitcoin/bitcoin/).
    
    [
      {
        "status": 1,
        "closing_reason": null,
        "closing_date": null,
        "capacity": 200000000,
        "short_id": "855248x2989x1",
        "id": "940355120828055553",
        "fee_rate": 1,
        "node": {
          "alias": "yalls.org clearnet-yalls",
          "public_key": "0288be11d147e1525f7f234f304b094d6627d2c70f3313d7ba3696887b261c4447",
          "channels": 93,
          "capacity": "6651565060"
        }
      },
      {
        "status": 1,
        "closing_reason": null,
        "closing_date": null,
        "capacity": 150000000,
        "short_id": "865606x2919x1",
        "id": "951743862263971841",
        "fee_rate": 100,
        "node": {
          "alias": "Megalithic.me",
          "public_key": "0322d0e43b3d92d30ed187f4e101a9a9605c3ee5fc9721e6dac3ce3d7732fbb13e",
          "channels": 83,
          "capacity": "6584980682"
        }
      },
      {
        "status": 1,
        "closing_reason": null,
        "closing_date": null,
        "capacity": 150000000,
        "short_id": "867452x3629x1",
        "id": "953773560775376897",
        "fee_rate": 2000,
        "node": {
          "alias": "cyberdyne.sh",
          "public_key": "03a93b87bf9f052b8e862d51ebbac4ce5e97b5f4137563cd5128548d7f5978dda9",
          "channels": 196,
          "capacity": "8511550562"
        }
      },
      {
        "status": 1,
        "closing_reason": null,
        "closing_date": null,
        "capacity": 115000000,
        "short_id": "827084x1086x1",
        "id": "909388475218657281",
        "fee_rate": 1000,
        "node": {
          "alias": "yalls.org yalls-tor",
          "public_key": "03d06758583bb5154774a6eb221b1276c9e82d65bbaceca806d90e20c108f4b1c7",
          "channels": 74,
          "capacity": "3241046701"
        }
      },
      {
        "status": 1,
        "closing_reason": null,
        "closing_date": null,
        "capacity": 100000000,
        "short_id": "740620x2091x0",
        "id": "814320301900496896",
        "fee_rate": 3000,
        "node": {
          "alias": "okx",
          "public_key": "0294ac3e099def03c12a37e30fe5364b1223fd60069869142ef96580c8439c2e0a",
          "channels": 612,
          "capacity": "73942283559"
        }
      },
      {
        "status": 1,
        "closing_reason": null,
        "closing_date": null,
        "capacity": 100000000,
        "short_id": "759240x2353x1",
        "id": "834793208426856449",
        "fee_rate": 2500,
        "node": {
          "alias": "nicehash-ln1",
          "public_key": "037659a0ac8eb3b8d0a720114efc861d3a940382dcfa1403746b4f8f6b2e8810ba",
          "channels": 1055,
          "capacity": "16787969802"
        }
      },
      {
        "status": 1,
        "closing_reason": null,
        "closing_date": null,
        "capacity": 100000000,
        "short_id": "810358x1309x6",
        "id": "890998043747090438",
        "fee_rate": 2000,
        "node": {
          "alias": "LNBϟG [Edge-4]",
          "public_key": "039edc94987c8f3adc28dab455efc00dea876089a120f573bd0b03c40d9d3fb1e1",
          "channels": 241,
          "capacity": "5095855252"
        }
      },
      {
        "status": 1,
        "closing_reason": null,
        "closing_date": null,
        "capacity": 100000000,
        "short_id": "822086x2856x1",
        "id": "903893116219031553",
        "fee_rate": 3000,
        "node": {
          "alias": "okx",
          "public_key": "0294ac3e099def03c12a37e30fe5364b1223fd60069869142ef96580c8439c2e0a",
          "channels": 612,
          "capacity": "73942283559"
        }
      },
      {
        "status": 1,
        "closing_reason": null,
        "closing_date": null,
        "capacity": 100000000,
        "short_id": "822104x753x1",
        "id": "903912907290509313",
        "fee_rate": 3000,
        "node": {
          "alias": "okx",
          "public_key": "0294ac3e099def03c12a37e30fe5364b1223fd60069869142ef96580c8439c2e0a",
          "channels": 612,
          "capacity": "73942283559"
        }
      },
      {
        "status": 1,
        "closing_reason": null,
        "closing_date": null,
        "capacity": 100000000,
        "short_id": "843151x2151x0",
        "id": "927054328611930112",
        "fee_rate": 2000,
        "node": {
          "alias": "Binance",
          "public_key": "03a1f3afd646d77bdaf545cceaf079bab6057eae52c6319b63b5803d0989d6a72f",
          "channels": 211,
          "capacity": "67249400000"
        }
      }
    ]
    
    
    Translations are periodically pulled from Transifex and merged into the git repository. See the
    [translation process](doc/translation_process.md) for details on how this works.
    
    **Important**: We do not accept translation changes as GitHub pull requests because the next
    pull from Transifex would automatically overwrite them again.
    6d183199ce
  3. DrahtBot commented at 7:46 am on January 20, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31688.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

  4. willcl-ark closed this on Jan 20, 2025

  5. bitcoin locked this on Jan 20, 2025
  6. fanquake renamed this:
    Update and rename README.md to GET /api/v1/lightning/channels?public_…
    .
    on Jan 20, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-01-21 03:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me