util: fix compiler warning about deprecated space before _MiB #31691

1. 
   vasild commented at 1:50 pm on January 20, 2025: contributor

   0src/util/byte_units.h:13:29: error: identifier '_MiB' preceded by whitespace in a literal operator declaration is deprecated [-Werror,-Wdeprecated-literal-operator]
   1   13 | constexpr size_t operator"" _MiB(unsigned long long mebibytes)
   2      |                  ~~~~~~~~~~~^~~~
   3      |                  operator""_MiB
   41 error generated.
   

   Clang 20.0.0

2. util: fix compiler warning about deprecated space before _MiB

   ```
   src/util/byte_units.h:13:29: error: identifier '_MiB' preceded by whitespace in a literal operator declaration is deprecated [-Werror,-Wdeprecated-literal-operator]
      13 | constexpr size_t operator"" _MiB(unsigned long long mebibytes)
         |                  ~~~~~~~~~~~^~~~
         |                  operator""_MiB
   1 error generated.
   ```
   
   Clang 20.0.0

   d3339a7cd5
3. 
   DrahtBot commented at 1:50 pm on January 20, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31691.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	TheCharlatan, maflcko

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. DrahtBot added the label Utils/log/libs on Jan 20, 2025
5. sedited approved
6. 
   sedited commented at 1:53 pm on January 20, 2025: contributor

   ACK d3339a7cd5f10e8a6b2a6c64daa66cd71a3e81d3
7. 
   maflcko commented at 2:06 pm on January 20, 2025: member

   lgtm ACK d3339a7cd5f10e8a6b2a6c64daa66cd71a3e81d3

   There should be an rc1 in two weeks, so the CI could be bumped to that to avoid issues in the future: https://llvm.org/docs/HowToReleaseLLVM.html#annual-release-schedule

8. fanquake merged this on Jan 20, 2025
9. fanquake closed this on Jan 20, 2025

   ---

10. vasild deleted the branch on Jan 20, 2025
11. 
    hebasto commented at 2:38 pm on January 20, 2025: member

    Post-merge ACK d3339a7cd5f10e8a6b2a6c64daa66cd71a3e81d3.
12. 
    hebasto commented at 3:58 pm on January 20, 2025: member

    There should be an rc1 in two weeks, so the CI could be bumped to that to avoid issues in the future: https://llvm.org/docs/HowToReleaseLLVM.html#annual-release-schedule

    In the meantime, I’ve added a nightly build that uses the LLVM Ubuntu nightly packages.

13. sedited referenced this in commit e1405325c9 on Feb 3, 2025
14. fanquake referenced this in commit 6a46be75c4 on Feb 10, 2025
15. stickies-v referenced this in commit d760fd3dda on Mar 17, 2025
16. stickies-v referenced this in commit cc83553352 on Mar 17, 2025
17. stickies-v referenced this in commit 2614933f06 on Mar 17, 2025
18. stickies-v referenced this in commit b70418c5fc on Mar 17, 2025
19. stickies-v referenced this in commit 69f8a1fe50 on Mar 17, 2025
20. bug-castercv502 referenced this in commit bf2e6853b0 on Sep 28, 2025
21. bitcoin locked this on Jan 20, 2026

Contributors
vasild DrahtBot sedited maflcko hebasto

Labels
Utils/log/libs