test: Bump sync_mempools timeout in p2p_1p1c_network.py #31701

1. 
   maflcko commented at 2:38 pm on January 21, 2025: member

   This should address the two issues that happened in https://github.com/bitcoin/bitcoin/actions/runs/12885576442/job/35924329657?pr=25832#step:6:7601:

   • The combined log isn’t printed on a test failure.
   • The timeout is too strict for the GHA virtual machines.

   For reference, the output was:

    0...
    1149/315 - rpc_blockchain.py --v2transport passed, Duration: 10 s
    2150/315 - p2p_addrfetch.py passed, Duration: 1 s
    3151/315 - p2p_1p1c_network.py failed, Duration: 31 s
    4
    5stdout:
    62025-01-21T12:05:49.465000Z TestFramework (INFO): PRNG seed is: 6581340712385622842
    72025-01-21T12:05:49.466000Z TestFramework (INFO): Initializing test directory /tmp/test_runner_₿_🏃_20250121_120233/p2p_1p1c_network_207
    82025-01-21T12:05:52.408000Z TestFramework (INFO): Fill mempools with large transactions to raise mempool minimum feerates
    92025-01-21T12:05:52.408000Z TestFramework (INFO): Fill the mempool until eviction is triggered and the mempoolminfee rises
   102025-01-21T12:05:59.692000Z TestFramework (INFO): Pre-send some transactions to nodes
   112025-01-21T12:06:00.203000Z TestFramework (INFO): Submit full packages to node0
   122025-01-21T12:06:00.220000Z TestFramework (INFO): Wait for mempools to sync
   132025-01-21T12:06:20.384000Z TestFramework (ERROR): Assertion failed
   14Traceback (most recent call last):
   15  File "/home/runner/work/bitcoin/bitcoin/test/functional/test_framework/test_framework.py", line 135, in main
   16    self.run_test()
   17  File "/home/runner/work/bitcoin/bitcoin/build/test/functional/p2p_1p1c_network.py", line 153, in run_test
   18    self.sync_mempools(timeout=20)
   19  File "/home/runner/work/bitcoin/bitcoin/test/functional/test_framework/test_framework.py", line 803, in sync_mempools
   20    raise AssertionError("Mempool sync timed out after {}s:{}".format(
   21AssertionError: Mempool sync timed out after 20s:
   22...
   

2. ci: Add missing --combinedlogslen to test-each-commit task 1111b0ac19
3. test: Bump sync_mempools timeout in p2p_1p1c_network.py fa80a7dac4
4. 
   DrahtBot commented at 2:38 pm on January 21, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31701.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	glozow, l0rinc

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

5. DrahtBot renamed this:
   test: Bump sync_mempools timeout in p2p_1p1c_network.py
   test: Bump sync_mempools timeout in p2p_1p1c_network.py
   on Jan 21, 2025
6. DrahtBot added the label Tests on Jan 21, 2025
7. 
   glozow commented at 3:30 pm on January 21, 2025: member

   ACK fa80a7dac4be8a1d8e32d88e46da23f14e06bade

   Makes sense to me. There are 4 nodes on p2p_1p1c_network, so makes sense that it could take longer than 20sec for everything to propagate. Default is 60 iirc?

8. 
   l0rinc commented at 3:36 pm on January 21, 2025: contributor

   utACK fa80a7dac4be8a1d8e32d88e46da23f14e06bade

   Same happened in https://github.com/bitcoin/bitcoin/actions/runs/12888898958/job/35934893317?pr=31699

9. fanquake merged this on Jan 21, 2025
10. fanquake closed this on Jan 21, 2025

    ---

11. maflcko deleted the branch on Jan 21, 2025
12. 
    maflcko commented at 9:05 am on January 23, 2025: member

    Looks like this still happens: #31713 (comment)

    So this is likely a non-timeout issue. Note that the test has immediate tx-relay (self.noban_tx_relay) enabled, so trickle delay should not be an issue.

Contributors
maflcko DrahtBot glozow l0rinc

Labels
Tests