p2p_orphan_handling checks whether a message has not been requested slightly too soon, making the check always succeed. This passes unnoticed since the expected result is for the message to not have been received, but it will make the test not catch a relevant change that should make it fail.
An easy way to check this is the case is to modify one of the test cases to force a request within the expected time, and check how the request is not seen. After the change, the test would crash as expected:
0index 963d92485c..30ab5f2035 100755
1--- a/test/functional/p2p_orphan_handling.py
2+++ b/test/functional/p2p_orphan_handling.py
3@@ -186,9 +185,12 @@ class OrphanHandlingTest(BitcoinTestFramework):
4 parent_inv = CInv(t=MSG_WTX, h=int(tx_parent_arrives["tx"].getwtxid(), 16))
5 assert_equal(len(peer_spy.get_invs()), 0)
6 peer_spy.assert_no_immediate_response(msg_getdata([parent_inv]))
7+ txid = 0xdeadbeef
8+ peer_spy.send_and_ping(msg_inv([CInv(t=MSG_WTX, h=txid)]))
9
10 # Request would be scheduled with this delay because it is not a preferred relay peer.
11 self.nodes[0].bumpmocktime(NONPREF_PEER_TX_DELAY)
12+ peer_spy.assert_never_requested(int(txid))
13 peer_spy.assert_never_requested(int(tx_parent_arrives["txid"], 16))
14 peer_spy.assert_never_requested(int(tx_parent_doesnt_arrive["txid"], 16))
15 # Request would be scheduled with this delay because it is by txid.
It is worth noting that this is not seen in the cases where the message is expected to be received, because in such cases assert_never_requested is always after a wait_.... method, which is already waiting for the node to sync on their end.
