Prepare “Open Transifex translations for v29.0” release step #31809

pull hebasto wants to merge 3 commits into bitcoin:master from hebasto:250206-translations changing 5 files +1283 −1236
  1. hebasto commented at 10:44 am on February 6, 2025: member

    This PR follows our Release Process.

    It is required to open Transifex translations for v29.0, as scheduled in #31029.

    The previous similar PR: #30548.

    Notes for reviewers:

    1. This is the first release process conducted after migrating the build system to CMake. This revealed a bug, which is fixed in the second commit

    2. To reproduce the diff in the third commit, follow these steps:

    0gmake -C depends -j $(nproc) MULTIPROCESS=1
    1cmake --preset dev-mode --toolchain depends/$(./depends/config.guess)/toolchain.cmake
    2cmake --build build_dev_mode --target translate
    
  2. Update Transifex slug for 29.x
    Update the Transifex slug to match the new resource created for the
    upcoming 29.x branch.
    2b51dd384b
  3. cmake: Ensure generated sources are up to date for `translate` target
    Some sources might be generated, and while they likely do not contain
    any translatable strings, this change generalizes the approach to
    include generated sources in the translation process as well.
    864386a744
  4. qt: Update the `src/qt/locale/bitcoin_en.xlf` translation source file
    Steps to reproduce the diff:
    ```
    $ gmake -C depends -j $(nproc) MULTIPROCESS=1
    $ cmake --preset dev-mode --toolchain depends/$(./depends/config.guess)/toolchain.cmake
    $ cmake --build build_dev_mode --target translate
    ```
    2f27c91086
  5. hebasto added the label GUI on Feb 6, 2025
  6. hebasto added this to the milestone 29.0 on Feb 6, 2025
  7. DrahtBot commented at 10:44 am on February 6, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31809.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK stickies-v

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  8. hebasto commented at 10:49 am on February 6, 2025: member

    cc @stickies-v @pablomartin4btc @johnny9 @jarolrod as regular reviewers of similar previous PRs.

    cc @l0rinc as the author of #31731.

    cc @glozow as the 29.0 release manager.

  9. stickies-v approved
  10. stickies-v commented at 3:40 pm on February 6, 2025: contributor

    ACK 2f27c910869e301b7e7669e81a0878da64e49957

    I’m not sure how necessary 864386a7444fb5cf16613956ce8bf335f51b67d5 is (has this lead to an issue before?), but the rationale makes sense, and it seems harmless and a minimal change.

    I reviewed 2f27c910869e301b7e7669e81a0878da64e49957 without depends and with -DWITH_MULTIPROCESS=OFF because the sources lists of bitcoin-qt and bitcoin-gui are currently identical. Diff is the same.

  11. hebasto merged this on Feb 6, 2025
  12. hebasto closed this on Feb 6, 2025

  13. hebasto deleted the branch on Feb 6, 2025
  14. jarolrod commented at 2:33 am on February 7, 2025: member
    post merge ack


hebasto DrahtBot stickies-v jarolrod

Labels
GUI

Milestone
29.0


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-03-09 12:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me