. #31876

issue kousay311 openend this issue on February 15, 2025
  1. kousay311 commented at 6:36 am on February 15, 2025: none

    Motivation

    // Good: UpperCamelCase standalone function name std::unique_ptr MakeNode(LocalInit& init);

    // Bad: lowercase standalone function std::unique_ptr makeNode(LocalInit& init);

    Possible solution

    // Good: UpperCamelCase standalone function name std::unique_ptr MakeNode(LocalInit& init);

    // Bad: lowercase standalone function std::unique_ptr makeNode(LocalInit& init); // Good: lowerCamelCase method name virtual void blockConnected(const CBlock& block, int height) = 0;

    // Bad: uppercase class method virtual void BlockConnected(const CBlock& block, int height) = 0;

    Useful Skills

    • Compiling Bitcoin Core from source
    • Running the C++ unit tests and the Python functional tests

    Guidance for new contributors

    Want to work on this issue?

    For guidance on contributing, please read CONTRIBUTING.md before opening your pull request.

  2. kousay311 added the label good first issue on Feb 15, 2025
  3. fanquake closed this on Feb 15, 2025

  4. fanquake removed the label good first issue on Feb 15, 2025
  5. fanquake renamed this:
    3
    .
    on Feb 19, 2025
  6. bitcoin locked this on Feb 19, 2025


kousay311


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-02-22 06:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me