make -logtimestamps default on and rework help-message #3188

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:logtimestamp_def changing 1 files +2 −2
  1. Diapolo commented at 10:38 AM on October 30, 2013: none

    It's IMHO much easier to work with debug.log, if timestamps are shown, which I think @sipa also mentioned some days ago.

  2. wtogami commented at 6:16 AM on October 31, 2013: contributor

    ACK

  3. petertodd commented at 3:22 PM on November 1, 2013: contributor

    ACK

  4. sipa commented at 1:52 PM on November 2, 2013: member

    ACK, though I'd go further and remove -logtimestamps entirely.

    Rebase please.

  5. make -logtimestamps default on and rework help-message 959e62f0c8
  6. Diapolo commented at 9:44 PM on November 2, 2013: none

    Rebased...

  7. BitcoinPullTester commented at 10:06 PM on November 2, 2013: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/959e62f0c889788e7775d5953668ce0cc5c1fea8 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

  8. mikehearn commented at 11:46 AM on November 3, 2013: contributor

    As an interesting bit of history, IIRC the reason they were off by default is that Satoshi had a paranoia attack and was worried about someone gathering logs from lots of nodes to correlate timestamps. In a world where intelligence agencies tap major fibre backbones and other people simply connect to every node and time relays, it seems clear to me that the value of having more useful logs massively outweighs that concern.

  9. sipa commented at 12:58 PM on November 3, 2013: member

    Agree with @mikehearn here.

  10. laanwj commented at 1:36 PM on November 3, 2013: member

    ACK

  11. laanwj referenced this in commit c4f2a002ca on Nov 4, 2013
  12. laanwj merged this on Nov 4, 2013
  13. laanwj closed this on Nov 4, 2013
  14. Diapolo deleted the branch on Nov 4, 2013
  15. Bushstar referenced this in commit 70b320bab0 on Apr 8, 2020
  16. DrahtBot locked this on Sep 8, 2021
Contributors
DiapolowtogamipetertoddsipaBitcoinPullTestermikehearnlaanwj
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 18:16 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me