cli: return local services in -netinfo

jonatack commented at 6:31 pm on February 16, 2025: member

Add local services info to -netinfo dashboard that already provides this info for each of the peer connections

default report with bitcoin-cli -netinfo

 0Bitcoin Core client v28.99.0 - server 70016/Satoshi:28.99.0/
 1
 2         ipv4    ipv6   onion     i2p   cjdns   total   block  manual
 3in          0       0      12       8       0      20
 4out         6       0       4       3       2      15       3       4
 5total       6       0      16      11       2      35
 6
 7Local services: network, bloom, witness, compact filters, network limited, p2p v2
 8
 9Local addresses
10--------------------------------------------------------.onion     port   8333    score      4
11--------------------------------------------------------.i2p       port      0    score      4
12fc32:----:----:----:----:----:----:----                            port   8333    score      1

with peers list, e.g. live dashboard using watch --no-title bitcoin-cli -netinfo 3

 0Bitcoin Core client v28.99.0 - server 70016/Satoshi:28.99.0/ - services nbwcl2
 1
 2<->   type   net   serv  v  mping   ping send recv  txn  blk  hb addrp addrl  age  asmap  id version
 3 in        onion         1    283    498   48   48    *              .         77        388 70016
 4 in        onion   nwl2  2    318    485    5  111                             79        372 70016/Satoshi:28.0.0/
 5 in        onion    nwl  1    342    344    4    1   53             96         84        344 70016/Satoshi:26.0.0/
 6 in        onion    nwl  1    411    601    4    1   35            124         85        339 70016/Satoshi:26.0.0/
 7 in        onion  nwcl2  2    436   4330    2    2    2             31         13        623 70016/Satoshi:28.0.0/
 8 in        onion    wl2  2    445    503    4    4    6            138         81        363 70016/Satoshi:28.0.0/
 9 in        onion    nwl  1    462    726    4    1   56             92         81        365 70016/Satoshi:23.0.0/
10 in        onion    nwl  1    500    765    4    1   34             94         83        351 70016/Satoshi:25.0.0/
11 in        onion   nwl2  2    578    684    4    0    1            134         87        327 70016/Satoshi:28.0.0/
12 in          i2p   nwl2  2    712   1322    4    2   35            204     1   93        308 70016/Satoshi:27.2.0/
13 in        onion   nwl2  2    727    873    5    5   56            162         85        342 70016/Satoshi:27.1.0/
14 in          i2p   nwl2  2    749    976    4    2   25            120         72        408 70016/Satoshi:27.1.0/
15 in          i2p   nwl2  2    776    954    4    1    0             72         68        426 70016/Satoshi:28.0.0/
16 in          i2p   nbwl  1    883   1735    4    4                  53         34        551 70016/Satoshi:26.0.0/
17 in          i2p  nwcl2  2    920   1044    2    0    0            131         83        350 70016/Satoshi:28.0.0/
18 in        onion     wl  1   1021  20832   29   67                   3         49        501 70016/Satoshi:23.0.0/
19 in          i2p  nwcl2  2   1830   1830    5    0                   3          3        668 70016/Satoshi:27.1.0/
20 in        onion    nwl  1  41155  41155   87  204                              4        658 70016/Satoshi:25.0.0/
21out   full  ipv4   nwl2  2     74     93    0    0    0           1028         85   1221 338 70016/Satoshi:27.1.0/
22out   full  ipv4    nwl  1     82    104    0    2    0    5  .   1076         95  13536 301 70016/Satoshi:26.0.0/
23out   full  ipv4    nwl  1    147    178    2    2    0   28  .   1104         95 395570 300 70016/Satoshi:25.0.0/
24out  block  ipv4   nwl2  2    166    513    2    2    *              .         88  38001 324 70016/Satoshi:27.2.0/
25out   full  ipv4     wl  1    193    201    0    4    0           1035         94  31376 307 70016/Satoshi:25.99.0/
26out   full  ipv4   nwl2  2    199    796    1    1    0           1027         94   9723 304 70016/Satoshi:27.2.0/
27out manual cjdns   nwl2  2    213    235    1    9    0           1109         83        353 70016/Satoshi:28.99.0/
28out   full onion   nbwl  1    282    457    3    3    1           1130         73        404 70016/Satoshi:25.0.0/
29out  block onion   nbwl  1    324    353   23   23    *              .         85        341 70016/Satoshi:26.0.0/
30out manual cjdns   nwl2  2    340    445    1    1    7           1059         82        361 70016/Satoshi:27.0.0/
31out manual onion    wl2  2    386    386    1    1    1           1048         84        345 70016/Satoshi:28.99.0/
32out manual   i2p  nwcl2  2    697   1084    1    1    8           1113     3   93        310 70016/Satoshi:27.0.0/
33out   full   i2p  nwcl2  2    730   1254    1    9    0           1128         89        318 70016/Satoshi:28.0.0/
34out   full   i2p  nwcl2  2    765   1804    1    1    1           1132         72        409 70016/Satoshi:28.0.0/
35                               ms     ms  sec  sec  min  min                  min
36
37         ipv4    ipv6   onion     i2p   cjdns   total   block  manual
38in          0       0      12       6       0      18
39out         6       0       3       3       2      14       2       4
40total       6       0      15       9       2      32
41
42Local addresses
43--------------------------------------------------------.onion     port   8333    score      4
44--------------------------------------------------------.i2p       port      0    score      4
45fc32:----:----:----:----:----:----:----                            port   8333    score      1

netinfo: return local services in the default report 3851960576

netinfo: return shortened services, if peers list requested

When the detailed peers list is requested, return the shortened services in the
-netinfo header in the same format as the "serv" column, instead of the full names
list in the report.

724546e28a

DrahtBot commented at 6:31 pm on February 16, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31886.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	zaidmstrr

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

DrahtBot added the label Scripts and tools on Feb 16, 2025

zaidmstrr commented at 6:18 pm on February 20, 2025: none

Code ACK 724546e I tested the changes on Ubuntu 24.04.2, and it’s working fine. I also manually reviewed the changed code for any logical errors. Although it’s very beneficial to check the node advertising services in a quick way.

cli: return local services in -netinfo #31886

Code Coverage & Benchmarks

Reviews