random: move VerifyRNDRRS above InitHardwareRand #31902

1. 
   eval-exec commented at 9:51 am on February 19, 2025: contributor

   Fix: #31826 (review)

   Friendly request @maflcko review.

2. random: move VerifyRNDRRS above InitHardwareRand, fix https://github.com/bitcoin/bitcoin/pull/31826#discussion_r1961315638

   Signed-off-by: Eval EXEC <execvy@gmail.com>

   82f3d89c6d
3. 
   DrahtBot commented at 9:51 am on February 19, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31902.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

4. eval-exec renamed this:
   random: move VerifyRNDRRS above InitHardwareRand, fix https://github.com/bitcoin/bitcoin/pull/31826#discussion_r1961315638
   random: move VerifyRNDRRS above InitHardwareRand
   on Feb 19, 2025
5. maflcko added this to the milestone 29.0 on Feb 19, 2025
6. maflcko added the label Utils/log/libs on Feb 19, 2025
7. DrahtBot added the label CI failed on Feb 19, 2025
8. DrahtBot removed the label CI failed on Feb 19, 2025
9. 
   eval-exec commented at 1:32 pm on February 19, 2025: contributor

   Why a CI failed label is added? I didn’t notice which CI workflow is failed.
10. 
    darosior commented at 3:39 pm on February 19, 2025: member

    I think for now it’s safer to just revert the original PR. See #31908. The changes can be re-considered and re-reviewed after the 29.0 branch-off.
11. 
    achow101 commented at 6:00 pm on February 19, 2025: member

    Still fails on AWS Graviton:

    0/home/ec2-user/bitcoin/src/random.cpp: In function ‘bool {anonymous}::VerifyRNDRRS()’:
    1/home/ec2-user/bitcoin/src/random.cpp:204:13: error: ‘GetRNDRRSInternal’ was not declared in this scope
    2  204 |         if (GetRNDRRSInternal(test)) {
    3      |             ^~~~~~~~~~~~~~~~~
    4gmake[2]: *** [src/util/CMakeFiles/bitcoin_util.dir/build.make:440: src/util/CMakeFiles/bitcoin_util.dir/__/random.cpp.o] Error 1
    5gmake[1]: *** [CMakeFiles/Makefile2:940: src/util/CMakeFiles/bitcoin_util.dir/all] Error 2
    

12. achow101 referenced this in commit fd14995b6a on Feb 19, 2025
13. glozow removed this from the milestone 29.0 on Feb 19, 2025
14. 
    glozow commented at 6:40 pm on February 19, 2025: member

    Closing since #31908 was merged.
15. glozow closed this on Feb 19, 2025

    ---

Contributors
eval-exec DrahtBot darosior achow101 glozow

Labels
Utils/log/libs