random: move VerifyRNDRRS above InitHardwareRand #31902

pull eval-exec wants to merge 1 commits into bitcoin:master from eval-exec:exec/fixVerifyRNDRRS changing 1 files +15 −15

eval-exec commented at 9:51 AM on February 19, 2025: contributor

Fix: #31826 (review)

Friendly request @maflcko review.
random: move VerifyRNDRRS above InitHardwareRand, fix https://github.com/bitcoin/bitcoin/pull/31826#discussion_r1961315638
Signed-off-by: Eval EXEC <execvy@gmail.com>
82f3d89c6d
DrahtBot commented at 9:51 AM on February 19, 2025: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31902.



Reviews

See the guideline for information on the review process. A summary of reviews will appear here.
eval-exec renamed this:
~~random: move VerifyRNDRRS above InitHardwareRand, fix https://github.com/bitcoin/bitcoin/pull/31826#discussion_r1961315638~~
random: move VerifyRNDRRS above InitHardwareRand
on Feb 19, 2025
maflcko added this to the milestone 29.0 on Feb 19, 2025
maflcko added the label Utils/log/libs on Feb 19, 2025
DrahtBot added the label CI failed on Feb 19, 2025
DrahtBot removed the label CI failed on Feb 19, 2025
eval-exec commented at 1:32 PM on February 19, 2025: contributor

Why a CI failed label is added? I didn't notice which CI workflow is failed.
darosior commented at 3:39 PM on February 19, 2025: member

I think for now it's safer to just revert the original PR. See #31908. The changes can be re-considered and re-reviewed after the 29.0 branch-off.

achow101 commented at 6:00 PM on February 19, 2025: member

Still fails on AWS Graviton:

/home/ec2-user/bitcoin/src/random.cpp: In function ‘bool {anonymous}::VerifyRNDRRS()’:
/home/ec2-user/bitcoin/src/random.cpp:204:13: error: ‘GetRNDRRSInternal’ was not declared in this scope
  204 |         if (GetRNDRRSInternal(test)) {
      |             ^~~~~~~~~~~~~~~~~
gmake[2]: *** [src/util/CMakeFiles/bitcoin_util.dir/build.make:440: src/util/CMakeFiles/bitcoin_util.dir/__/random.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:940: src/util/CMakeFiles/bitcoin_util.dir/all] Error 2

achow101 referenced this in commit fd14995b6a on Feb 19, 2025
glozow removed this from the milestone 29.0 on Feb 19, 2025
glozow commented at 6:40 PM on February 19, 2025: member

Closing since #31908 was merged.
glozow closed this on Feb 19, 2025

Contributors

Labels

Linked (view graph)

#31826 random: Check `GetRNDRRS` is supported in `InitHardwareRand` to avoid infinite loop #31908 Revert merge of PR #31826 #31912 random: Initialize variables in hardware RNG functions

random: move VerifyRNDRRS above InitHardwareRand #31902

Code Coverage & Benchmarks

Reviews