Add assumeutxo chainparams to release-process.md

willcl-ark commented at 5:10 pm on February 23, 2025: member

This should ideally be bumped every major (and perhaps even minor?) release to avoid falling too far behind, and therefore keeping this feature as useful as it can be.

Document in release-process.md to avoid forgetting to do this.

DrahtBot commented at 5:10 pm on February 23, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31940.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	achow101, glozow
Concept ACK	hodlinator, Sjors
Stale ACK	pablomartin4btc

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

maflcko added this to the milestone 29.0 on Feb 24, 2025

pablomartin4btc commented at 2:47 pm on February 25, 2025: member

ACK 8b5a50cb353d9524db38a3cfd537bac7a770e1a6

in doc/release-process.md:47 in 8b5a50cb35 outdated

43@@ -44,6 +44,7 @@ Release Process
44     - On mainnet, the selected value must not be orphaned, so it may be useful to set the height two blocks back from the tip.
45     - Testnet should be set with a height some tens of thousands back from the tip, due to reorgs there.
46   - `nMinimumChainWork` with the "chainwork" value of RPC `getblockheader` using the same height as that selected for the previous step.
47+  - `m_assumeutxo_data` array can be appended to with the (partial) output of the `gettxoutsetinfo "hash_serialized_3 <target_block_height>"` RPC. The same height considerations as for `defaultAssumeValid` apply.

yancyribbens commented at 10:31 pm on February 26, 2025:

0  - `m_assumeutxo_data` array can be appended to with the (partial) output of the `gettxoutsetinfo "hash_serialized_3 <target_block_height>"` RPC. The same height considerations for `defaultAssumeValid` apply.

rkrux commented at 3:25 pm on February 28, 2025:

can be appended

can be or should be?

If it’s important enough to be a part of the release process, might as well enforce it? At least for mainnet, can be optional for test envs?

hodlinator commented at 9:10 pm on March 1, 2025:

Must be holding it wrong, but the gettxoutsetinfo-RPC isn’t allowing me to specify both a hash_type and block height?

rkrux commented at 8:12 am on March 3, 2025:

Yes, I see the same issue. This is as per the code: https://github.com/bitcoin/bitcoin/blob/master/src/rpc/blockchain.cpp#L1019-L1021

Following commands work for me instead:

0bitcoincli gettxoutsetinfo
1bitcoincli gettxoutsetinfo muhash <block-height>
2bitcoincli gettxoutsetinfo none <block-height>

willcl-ark commented at 8:03 pm on March 3, 2025:

addressed in 9dcf4b6c4d183ab069459b9be49ef7acd7d3be4b

willcl-ark commented at 8:03 pm on March 3, 2025:

changed to “should” in 9dcf4b6c4d183ab069459b9be49ef7acd7d3be4b

willcl-ark commented at 8:09 pm on March 3, 2025:

Thanks for the check! I actually called invalidateblock and then gettxoutsetinfo when testing this. I figured gettxoutsetinfo <hash> <block_height> was permitted from skimming the RPC helptext, but I didnt’ verify!

As this doesn’t work, I reverted to my tested method of invalidateblock followed by gettxoutsetinfo in 9dcf4b6c4d183ab069459b9be49ef7acd7d3be4b (please let me know if there is a better method I’m missing)

pablomartin4btc commented at 11:26 pm on March 3, 2025:

Just for reference (“hash_serialized_3 hash type cannot be queried for a specific block”): https://github.com/bitcoin/bitcoin/blob/afde95b4601e6ac44b9fa313747c28b656d1faf2/test/functional/feature_coinstatsindex.py#L296-L303

Sjors commented at 4:02 pm on March 1, 2025: member

See #31969 for a potential v29 snapshot.

hodlinator commented at 9:12 pm on March 1, 2025: contributor

Concept ACK

Should we also add a later step in the release process for the actual generation of the assumeutxo snapshot, maybe referencing doc/assumeutxo.md?

willcl-ark commented at 9:13 pm on March 1, 2025: member

We could do. Sjors has a tidy command in the linked PR.

Sjors commented at 12:11 pm on March 3, 2025: member

Concept ACK

Every major release seems plenty, same as assumevalid.

willcl-ark force-pushed on Mar 3, 2025

pablomartin4btc commented at 11:26 pm on March 3, 2025: member

reACK 9dcf4b6c4d183ab069459b9be49ef7acd7d3be4b

DrahtBot requested review from Sjors on Mar 3, 2025

DrahtBot requested review from hodlinator on Mar 3, 2025

doc: add assumeutxo chainparams to release proc

This should be bumped every major release to avoid falling too far
behind, therefore making this feature as useful as it can be.

Document this in release-process.md to avoid forgetting to add a new
hardcoded height during release.

02fae33635

in doc/release-process.md:47 in 9dcf4b6c4d outdated

43@@ -44,6 +44,8 @@ Release Process
44     - On mainnet, the selected value must not be orphaned, so it may be useful to set the height two blocks back from the tip.
45     - Testnet should be set with a height some tens of thousands back from the tip, due to reorgs there.
46   - `nMinimumChainWork` with the "chainwork" value of RPC `getblockheader` using the same height as that selected for the previous step.
47+  - `m_assumeutxo_data` array should be appended to with the (partial) output of the `gettxoutsetinfo` RPC after `invalidateblock <block_height>` has been called.

achow101 commented at 11:58 pm on March 3, 2025:

Can we explicitly list out which things to take from the output?

Also, perhaps it would be better to use dumptxoutset which gives all of the same data, and it can automatically roll back and forward.

hodlinator commented at 9:41 am on March 4, 2025:

Can we explicitly list out which things to take from the output?

While testing #31969 and using dumptxoutset I didn’t feel the need for documentation on individual fields as long as there are prior m_assumeutxo_data-entries. If we keep gettxoutsetinfo though, the output seems to map less directly, so in that case I agree listing them might be useful.

Sjors commented at 9:43 am on March 4, 2025:

dumptxoutset was designed for this task (originally a contrib bash script), so it seems better to use it.

willcl-ark commented at 9:47 am on March 4, 2025:

Updated to use dumptxoutset in 02fae3363511e96a76ff64a4513c7a7e8d8d4403

willcl-ark force-pushed on Mar 4, 2025

achow101 commented at 5:54 pm on March 4, 2025: member

ACK 02fae3363511e96a76ff64a4513c7a7e8d8d4403

DrahtBot requested review from pablomartin4btc on Mar 4, 2025

glozow referenced this in commit e13c18f6ce on Mar 4, 2025

glozow commented at 7:42 pm on March 4, 2025: member

ACK 02fae3363511e96a76ff64a4513c7a7e8d8d4403

glozow merged this on Mar 4, 2025

glozow closed this on Mar 4, 2025

Add assumeutxo chainparams to release-process.md #31940

Code Coverage & Benchmarks

Reviews