Drop testnet3

Sjors commented at 4:22 pm on March 3, 2025: member

Testnet3 was deprecated in v28 with the introduction of testnet4. It will be dropped in v30 or later, please discuss in #31975.

There is no more [test] network section. The user is expected to set testnet4 explicitly, which should make future rotation of testnets easier.

If a [test] or [testnet3] section is present in bitcoin.conf a warning is issued:

0Warning: .../bitcoin.conf:18 Section [test] is not recognized.

Starting with -testnet3 will be greeted with an error message:

0Error: Testnet3 was dropped in version 30.0. Consider using '-testnet4' instead.

This also prevents a fallback to mainnet.

Starting with -test was already not possible with testnet3.

Builds on #31649 because it removes a test that relies on testnet3.

Review hints:

unsure if I got argsman_tests right
make a (Windows) Guix build and test the (un)installer

Guix hashes:

 0060f460a784f29753dec9ff9dd1adcc9cbd7d6bb4f4fbdd5288d76c31e2117ad  guix-build-434fe3f47271/output/aarch64-linux-gnu/SHA256SUMS.part
 1beebef9a3a07d3a89458e73a0117e8a3a13ace49c9e0d6d4381bfac83a14ae47  guix-build-434fe3f47271/output/aarch64-linux-gnu/bitcoin-434fe3f47271-aarch64-linux-gnu-debug.tar.gz
 2796a2f4c98152900e8bb6b41c9181ddbf4572f7051eeeb878b646d80957663a7  guix-build-434fe3f47271/output/aarch64-linux-gnu/bitcoin-434fe3f47271-aarch64-linux-gnu.tar.gz
 39b6ae63b8d7032ad7f5b725ff5c066d072a8eed0cb8de79f4fa024a7b461200c  guix-build-434fe3f47271/output/arm-linux-gnueabihf/SHA256SUMS.part
 47e4425b5a4355270f6b874f866c31e860ce4dde822b9bbbf0022780dea9842ab  guix-build-434fe3f47271/output/arm-linux-gnueabihf/bitcoin-434fe3f47271-arm-linux-gnueabihf-debug.tar.gz
 53262ca2269c4093520f81bb66c50ee64c0dc1dc00258f6e5b756cb12cf92277a  guix-build-434fe3f47271/output/arm-linux-gnueabihf/bitcoin-434fe3f47271-arm-linux-gnueabihf.tar.gz
 6d0003a24d6a11500a3de018a66ad15a6f39701a297e9868137c5c3fe072f7103  guix-build-434fe3f47271/output/arm64-apple-darwin/SHA256SUMS.part
 7c2a1af6e3347aed3920690f34ebb19f1a0c9d97f455545a7c1a586fe3326edfc  guix-build-434fe3f47271/output/arm64-apple-darwin/bitcoin-434fe3f47271-arm64-apple-darwin-unsigned.tar.gz
 86c86170746526c991f92bea85e03b951107ac62cf9524f59062aefcab7f6990e  guix-build-434fe3f47271/output/arm64-apple-darwin/bitcoin-434fe3f47271-arm64-apple-darwin-unsigned.zip
 9f810a140dcfd9e7c5b7679628147c690a0cd9ce0278fc94e65cd8818e3b1828e  guix-build-434fe3f47271/output/arm64-apple-darwin/bitcoin-434fe3f47271-arm64-apple-darwin.tar.gz
103c67e06ded7aab7b132a50516069b9a40afc0fe796a02155fed7c7310f5e4d22  guix-build-434fe3f47271/output/dist-archive/bitcoin-434fe3f47271.tar.gz
11daeadb4c25315cf18b5052f276760ef185e2b6f4f35b05e0a85e793dda0cc1f2  guix-build-434fe3f47271/output/powerpc64-linux-gnu/SHA256SUMS.part
12b8494f13982be059614fda2f8b6e0d1eb8a199a8a7c703465f5c720819f2b3eb  guix-build-434fe3f47271/output/powerpc64-linux-gnu/bitcoin-434fe3f47271-powerpc64-linux-gnu-debug.tar.gz
13cb57a9763bd3592618199fe634a88599242e29e9679640ddbb98edead0f8b00a  guix-build-434fe3f47271/output/powerpc64-linux-gnu/bitcoin-434fe3f47271-powerpc64-linux-gnu.tar.gz
14b9e3eb5e5ec31d1ef5bd59cd1daa2238723856e5a680273abb3d1c8003a2c3ae  guix-build-434fe3f47271/output/riscv64-linux-gnu/SHA256SUMS.part
156f4166d0644899f8858e8bf542fc1c5c6544b12375940f6feb9475401daf3b60  guix-build-434fe3f47271/output/riscv64-linux-gnu/bitcoin-434fe3f47271-riscv64-linux-gnu-debug.tar.gz
16d6a3a2d8a1cbab92d58d732eddacaa18bc09c73a2471ad84469b7bd08618351d  guix-build-434fe3f47271/output/riscv64-linux-gnu/bitcoin-434fe3f47271-riscv64-linux-gnu.tar.gz
17426f9d5114949381351c2e573e011fb46e1f0621bd0a8f85e44af6fa2a10b004  guix-build-434fe3f47271/output/x86_64-apple-darwin/SHA256SUMS.part
18cfd7d2f798982685fa594a88dba2abcba7de93b931beacef3104f97cb72c66b3  guix-build-434fe3f47271/output/x86_64-apple-darwin/bitcoin-434fe3f47271-x86_64-apple-darwin-unsigned.tar.gz
194d4c0c5834b175b838d158459c07c31f2a07ed20fbc6fff5b0c024918ffdf1b1  guix-build-434fe3f47271/output/x86_64-apple-darwin/bitcoin-434fe3f47271-x86_64-apple-darwin-unsigned.zip
200bd460abf51afd63add7e69370fe39dc4cef6b6a4d5abd2adb7ba00f091e8a94  guix-build-434fe3f47271/output/x86_64-apple-darwin/bitcoin-434fe3f47271-x86_64-apple-darwin.tar.gz
2198cee67f4b8bf17690b193e5826a8819869d7b04e4c2f00de622e1c177145b1e  guix-build-434fe3f47271/output/x86_64-linux-gnu/SHA256SUMS.part
221908c246af1931740f47f32e79b230dd666d169c8d349231ef598edc547a3fe3  guix-build-434fe3f47271/output/x86_64-linux-gnu/bitcoin-434fe3f47271-x86_64-linux-gnu-debug.tar.gz
23b2708475d18e639b14e1203aa1c4529317e23e647d3f3b7671369a6882702070  guix-build-434fe3f47271/output/x86_64-linux-gnu/bitcoin-434fe3f47271-x86_64-linux-gnu.tar.gz
24c498a9ef813eb80613a56612d9d93fc3e87d8d443a77f8aea40ef054b6d5071a  guix-build-434fe3f47271/output/x86_64-w64-mingw32/SHA256SUMS.part
259467e0bcc633122d623a50d3c07710800dcde536c80dd7e4dfd6343f168442aa  guix-build-434fe3f47271/output/x86_64-w64-mingw32/bitcoin-434fe3f47271-win64-debug.zip
2691b71addc9029c8c9e289d6388024c2b4682014ef139d2ac6fa0c2e38ff11b22  guix-build-434fe3f47271/output/x86_64-w64-mingw32/bitcoin-434fe3f47271-win64-setup-unsigned.exe
276722864ba7e717fd499d4a1acab7231e5663c97a8cd3e360beb5af84f8b2fc18  guix-build-434fe3f47271/output/x86_64-w64-mingw32/bitcoin-434fe3f47271-win64-unsigned.tar.gz
28de97e9c9a0d20f8b7bd9e5d18de4dd9aab998812b9aa14717dd64fe0e8b6fd05  guix-build-434fe3f47271/output/x86_64-w64-mingw32/bitcoin-434fe3f47271-win64.zip

update comment on MinimumChainWork check c59cbba518

Remove checkpoints

The headers presync logic should be enough to prevent memory DoS using
low-work headers. Therefore, we no longer have any use for checkpoints.

301017c621

DrahtBot commented at 4:22 pm on March 3, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31974.

Reviews

See the guideline for information on the review process.

Type	Reviewers
Concept ACK	fjahr

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#31978 (kernel: pre-29.x chainparams and headerssync update by glozow)
#31960 (seeds: update makeseeds regex and DNS fixed seeds by jonatack)
#31916 (init: Handle dropped UPnP support more gracefully by laanwj)
#31859 (test: Rename send_message to send_without_ping by maflcko)
#31564 (Add checkblock RPC and checkBlock() to Mining interface by Sjors)
#31260 (scripted-diff: Type-safe settings retrieval by ryanofsky)
#31250 (wallet: Disable creating and loading legacy wallets by achow101)
#30595 (kernel: Introduce initial C header API by TheCharlatan)
#29678 (Bugfix: Correct first-run free space checks by luke-jr)
#29641 (scripted-diff: Use LogInfo over LogPrintf [WIP, NOMERGE, DRAFT] by maflcko)
#29039 (versionbits refactoring by ajtowns)
#27260 (Enhanced error messages for invalid network prefix during address parsing. by russeree)
#26201 (Remove Taproot activation height by Sjors)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

instagibbs commented at 4:27 pm on March 3, 2025: member

I’ve said it elsewhere, but I think it deserves a quite long deprecation cycle, along with some data gathering.

We don’t want services not upgrading for fixes because their test environment would break.

e.g., what exchanges with testnet environments have adopted testnet4 (or signet), much less would be ok with removing testnet3?

Does btcd support it? LND? Eclaire? CLN? etc.

Lots of work to be done here imo.

Sjors commented at 4:30 pm on March 3, 2025: member

I opened a separate RFC to discuss when to drop testnet3: #31975

I can rebase this for a while if we decide v30 is too early.

zmq: use testnet4 in examples a898172189

test: drop unused testnet3 magic bytes 21b0df9e58

glozow added the label Tests on Mar 3, 2025

test: use testnet4 in key_io_valid.json f744794d55

test: use testnet4 in argsman test bc7acbdef5

fjahr commented at 8:04 pm on March 3, 2025: contributor

Concept ACK

doc: use testnet4 in developer docs 15a4e1cdbd

gui: drop testnet3 e37cacc0b1

test: drop testnet3 coverage

Except for the deprecation warning.
This test now writes its own config file, which was previously done by
test_acceptstalefeeestimates_arg_support. This code will be removed
once -testnet3 is dropped.

f4579d786c

Sjors force-pushed on Mar 3, 2025

Sjors commented at 9:30 pm on March 3, 2025: member

I split 5d6aa13cf047e31005afca919ca9cf181e30905b into smaller commits. If we decide to punt this until after v30 then I’ll PR some of these separately. E.g. there’s some tests that can use testnet4 instead of testnet3 and perhaps we can drop GUI support earlier.

Disallow -testnet3

Abort node startup and inform user they should use -testnet4.
Modify the deprecation message test to cover this.

Remove testnet3 references from bitcoin-cli documentation
and bash helper.

a90319d6be

Drop testnet3 seed nodes dd0004aeb9

Drop testnet3 from docs and dev tools

Also use "test network" instead of "testnet" where appropriate (e.g.
because it also applies to signet).

545bf31061

consensus: drop testnet3

This drops the chain parameters and ChainType::TESTNET.

4a3197b286

validation: drop testnet3 comment about BIP34 10bcc057b4

doc: add release note 434fe3f472

Sjors force-pushed on Mar 3, 2025

DrahtBot added the label Needs rebase on Mar 4, 2025

DrahtBot commented at 2:57 am on March 4, 2025: contributor

🐙 This pull request conflicts with the target branch and needs rebase.

Sjors commented at 9:35 am on March 4, 2025: member

Will rebase after #31649 is rebased.

Drop testnet3 #31974

Code Coverage & Benchmarks

Reviews

Conflicts