If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.
Conflicts
Reviewers, this pull request conflicts with the following ones:
#34004 (Implementation of SwiftSync by rustaceanrob)
#33861 (build: Bump VS minimum supported version to 18.0 by hebasto)
#32317 (kernel: Separate UTXO set access from validation functions by sedited)
#29678 (Bugfix: Correct first-run free space checks by luke-jr)
#27260 (Enhanced error messages for invalid network prefix during address parsing. by portlandhodl)
#26201 (Remove Taproot activation height by Sjors)
#17580 (refactor: Add ALLOW_LIST flags and enforce usage in CheckArgFlags by ryanofsky)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
LLM Linter (✨ experimental)
Possible typos and grammar issues:
REST-interface.md: “…by default port 8332 for mainnet,” -> “…defaulting to port 8332 for mainnet,” [“by default port …” is ungrammatical/awkward and can momentarily obscure that the following ports are the default values.]
2026-03-20 14:00:54
instagibbs
commented at 4:27 pm on March 3, 2025:
member
I’ve said it elsewhere, but I think it deserves a quite long deprecation cycle, along with some data gathering.
We don’t want services not upgrading for fixes because their test environment would break.
e.g., what exchanges with testnet environments have adopted testnet4 (or signet), much less would be ok with removing testnet3?
Does btcd support it? LND? Eclaire? CLN? etc.
Lots of work to be done here imo.
Sjors
commented at 4:30 pm on March 3, 2025:
member
I opened a separate RFC to discuss when to drop testnet3: #31975
I can rebase this for a while if we decide v30 is too early.
glozow added the label
Tests
on Mar 3, 2025
fjahr
commented at 8:04 pm on March 3, 2025:
contributor
Concept ACK
Sjors force-pushed
on Mar 3, 2025
Sjors
commented at 9:30 pm on March 3, 2025:
member
I split 5d6aa13cf047e31005afca919ca9cf181e30905b into smaller commits. If we decide to punt this until after v30 then I’ll PR some of these separately. E.g. there’s some tests that can use testnet4 instead of testnet3 and perhaps we can drop GUI support earlier.
Sjors force-pushed
on Mar 3, 2025
DrahtBot added the label
Needs rebase
on Mar 4, 2025
Sjors
commented at 9:35 am on March 4, 2025:
member
This whole test seems a bit confusing, especially with this comment. The goal of the test is to check that a wallet doesn’t load cross-chain silently. It seems confusing to mention testnet3 and testnet4 here, but no other networks. Either, all test networks are tested, or only a single one. I’d argue that a single one should be sufficient.
Thus, a clean revert of git show 74a04f9e7ad6a16988149cc3438b9ce13c91cdb9 ./test/functional/wallet_crosschain.py seems more appropriate. Then, a follow-up to use the most stable test chain (signet?) and add a comment that only one test chain needs to be checked. Possibly, even better would be to just use the main chain, but I am not sure if the diff is trivial.
In any case, this change can probably be peeled off into a fresh/separate pull, because it makes sense on its own.
40@@ -41,7 +41,7 @@ Comments may appear in two ways:
41 ### Network specific options
4243 Network specific options can be:
44-- placed into sections with headers `[main]` (not `[mainnet]`), `[test]` (not `[testnet]`, for testnet3), `[testnet4]`, `[signet]` or `[regtest]`;
45+- placed into sections with headers `[main]` (not `[mainnet]`), `[testnet4]`, `[signet]` or `[regtest]`;
hodlinator
commented at 9:10 pm on March 24, 2025:
hodlinator
commented at 9:12 pm on March 24, 2025:
Noticed while looking at #32096 that this file was untouched there.
Testnet3 has rpcport=18332 according to how chainparamsbase.cpp sets CBaseChainParams(..., rpc_port)…
This config is setting the P2P ports for all networks so that they will collide with the default RPC ports and prevent successful startup (verified with the mainnet config line). Might as well just remove all ports IMO.
I was mistaken, this config file is meant to be consumed by the linearize-(hashes|data).py scripts, not bitcoind. Using port in this context is referring to which port the RPC interface is expected to be running on when one connects as a client. Please resolve this thread.
in
test/functional/feature_assumeutxo.py:106
in
4e6e73a3b2outdated
I assume you’re talking about the chain argument? This is passed directly to HWI (or equivalent software). I’ll update the comment on the next rebase to swap “test” for “testnet4” which was missed when testnet4 was launched.
hodlinator
commented at 9:31 am on March 25, 2025:
Exactly, from what I could see it would be set from ArgsManager::GetChainTypeString() in one case and CChainParams::GetChainTypeString() in another.
Try to run the tests locally, according to the documentation. However, a CI failure may still
happen due to a number of reasons, for example:
Possibly due to a silent merge conflict (the changes in this pull request being
incompatible with the current code in the target branch). If so, make sure to rebase on the latest
commit of the target branch.
A sanitizer issue, which can only be found by compiling with the sanitizer and running the
affected test.
An intermittent issue.
Leave a comment here, if you need help tracking down a confusing failure.
Sjors
commented at 10:22 am on December 9, 2025:
member
DrahtBot removed the label
Needs rebase
on Dec 9, 2025
DrahtBot removed the label
CI failed
on Dec 9, 2025
DrahtBot added the label
Needs rebase
on Feb 11, 2026
doc: use "test nework" in external_signer.h5f1c3d4c04
doc: use signet=1 in bitcoin-conf.md example1e4270c7ff
gui: drop testnet3094642c1bc
test: drop testnet3 coverage
Except for the deprecation warning in feature_config_args.py.
This test now writes its own config file, which was previously done by
test_acceptstalefeeestimates_arg_support.
The deprecation warning test will be removed in a later commit.
4dea19d5e7
Disallow -testnet3
Abort node startup and inform user they should use -testnet4.
Modify the deprecation message test to cover this.
Remove testnet3 references from bitcoin-cli documentation
and bash helper.
24ae57c7e6
Drop testnet3 seed nodesf06845dd3f
Drop testnet3 from docs and dev tools
Also use "test network" instead of "testnet" where appropriate (e.g.
because it also applies to signet).
d822567b84
kernel: drop testnet3becf7ea98a
consensus: drop testnet3
This drops the chain parameters and ChainType::TESTNET.
2cbdcaf100
validation: drop testnet3 comment about BIP341685e4b424
doc: add release note45bf25e51b
Sjors force-pushed
on Mar 20, 2026
Sjors
commented at 2:00 pm on March 20, 2026:
member
Just a fresh rebase after #34673 which updated the testnet3 seed nodes that we’re dropping, and the v31 chainparams update in #34677.
DrahtBot removed the label
Needs rebase
on Mar 20, 2026
DrahtBot added the label
Needs rebase
on Mar 21, 2026
DrahtBot
commented at 0:13 am on March 21, 2026:
contributor
🐙 This pull request conflicts with the target branch and needs rebase.
This is a metadata mirror of the GitHub repository
bitcoin/bitcoin.
This site is not affiliated with GitHub.
Content is generated from a GitHub metadata backup.
generated: 2026-03-23 09:13 UTC
This site is hosted by @0xB10C More mirrored repositories can be found on mirror.b10c.me
