Make time facet non-constant #3198

pull nvmd wants to merge 1 commits into bitcoin:master from nvmd:compile_on_mavericks changing 1 files +1 −1
  1. nvmd commented at 9:04 PM on November 4, 2013: contributor

    This is supposed to fix #2806 (compilation problems on OSX 10.9:

    ...
      CXX      rpcdump.o
    In file included from rpcdump.cpp:5:
    In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/iostream:38:
    In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/ios:216:
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/__locale:144:29: error: 
          cannot initialize a parameter of type 'std::__1::locale::facet *' with an lvalue of type
          'const boost::date_time::time_input_facet<boost::posix_time::ptime, char,
          std::__1::istreambuf_iterator<char, std::__1::char_traits<char> > > *'
        __install_ctor(__other, __f, __f ? __f->id.__get() : 0);
                                ^~~
    rpcdump.cpp:31:23: note: in instantiation of function template specialization
          'std::__1::locale::locale<const
          boost::date_time::time_input_facet<boost::posix_time::ptime, char,
          std::__1::istreambuf_iterator<char, std::__1::char_traits<char> > > >' requested here
        const std::locale loc(std::locale::classic(), &facet);
                          ^
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/__locale:96:46: note: 
          passing argument to parameter here
        void __install_ctor(const locale&, facet*, long);
                                                 ^
    1 error generated.
    make[3]: *** [rpcdump.o] Error 1
    make[2]: *** [all-recursive] Error 1
    make[1]: *** [all] Error 2
    make: *** [all-recursive] Error 1
    ```)
    
  2. Make time facet non-constant e5a2c9794c
  3. BitcoinPullTester commented at 9:15 PM on November 4, 2013: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/e5a2c9794c34261af5ddcb8751913186d9802791 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

  4. sipa commented at 12:46 AM on November 5, 2013: member

    ACK

  5. gavinandresen referenced this in commit 63bea1d2e6 on Nov 5, 2013
  6. gavinandresen merged this on Nov 5, 2013
  7. gavinandresen closed this on Nov 5, 2013

  8. nvmd deleted the branch on Nov 5, 2013
  9. nvmd restored the branch on Nov 5, 2013
  10. nvmd deleted the branch on Jan 21, 2014
  11. BetaCoinDev referenced this in commit 20d6b5c076 on Apr 11, 2014
  12. BetaCoinDev referenced this in commit 763c89a9a6 on Apr 11, 2014
  13. Bushstar referenced this in commit 415b81e41e on Apr 8, 2020
  14. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-19 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me