Cleanup refactoring of coins/mempool #3199

pull sipa wants to merge 2 commits into bitcoin:master from sipa:mempoolmove changing 13 files +613 −605
  1. sipa commented at 1:59 AM on November 5, 2013: member

    This pull request should have no functional effects.

    • The first commit removes the CBlockIndex dependency of CCoinsView, making it reason in terms of block hashes (which it was doing under the hood anyway).
    • The second commit moves most CCoins/CCoinsView related logic to coins.{h,cpp}, and the rest to txmempool.{h,cpp}. This removes the need for the LookupFromTip loophole, as txmempool is just built on top of coins.
  2. gavinandresen commented at 6:22 AM on November 9, 2013: contributor

    These should move to coins.cpp, too, I think:

    main.cpp:const CTxOut &CCoinsViewCache::GetOutputFor(const CTxIn& input)
    main.cpp:int64 CCoinsViewCache::GetValueIn(const CTransaction& tx)
    main.cpp:bool CCoinsViewCache::HaveInputs(const CTransaction& tx)
    
  3. sipa commented at 5:17 PM on November 9, 2013: member

    @gavinandresen Nice catch, done.

  4. sipa commented at 11:00 PM on November 9, 2013: member

    Rebased.

  5. gavinandresen commented at 11:07 PM on November 9, 2013: contributor

    ACK assuming pull-tester is happy.

  6. sipa commented at 10:44 AM on November 10, 2013: member

    Let's delay this until #2767 is merged.

  7. Make CCoinsView use block hashes instead of indices 84674082b0
  8. Move CCoins-related logic to coins.{cpp.h} a0fa20a12b
  9. sipa commented at 6:41 PM on November 10, 2013: member

    Rebased on top of #2767.

  10. BitcoinPullTester commented at 7:04 PM on November 10, 2013: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/a0fa20a12b69717636050dd8742713b1d82ae524 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

  11. gavinandresen commented at 2:09 AM on November 11, 2013: contributor

    ACK; re-tested running -debug=mempool on the main network, with additional testing running a couple of -regtest peers (creating blocks, sending transactions back and forth, etc).

  12. gavinandresen referenced this in commit 7d7df381f8 on Nov 11, 2013
  13. gavinandresen merged this on Nov 11, 2013
  14. gavinandresen closed this on Nov 11, 2013

  15. Bushstar referenced this in commit 7aa9c43f89 on Apr 8, 2020
  16. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-19 09:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me