qt: Add addressList field to SendCoinsRecipient for multiple addresses #32035

pull VolodymyrBg wants to merge 5 commits into bitcoin:master from VolodymyrBg:BG changing 4 files +56 −13
  1. VolodymyrBg commented at 5:39 pm on March 11, 2025: none

    This pull request adds a new field addressList to the SendCoinsRecipient class to properly handle multiple addresses from unauthenticated payment requests. Previously, the address field was being abused for this purpose, as noted in a TODO comment.

    The changes include:

    • Adding a new addressList field to SendCoinsRecipient
    • Updating the serialization methods to handle the new field
    • Modifying PaymentServer to populate the new field when multiple addresses are present
    • Updating ReceiveRequestDialog to display and copy the address list when available
    • Adding support for the “addresses” parameter in Bitcoin URI parsing

    This provides a cleaner solution for handling multiple addresses in payment requests without abusing the single address field.

  2. Update sendcoinsrecipient.h 29ca24f362
  3. Update receiverequestdialog.cpp 48f738bf4c
  4. Update paymentserver.cpp c856ca7984
  5. Update guiutil.cpp 1a29c901a6
  6. Update receiverequestdialog.cpp 592599f7d2
  7. DrahtBot commented at 5:39 pm on March 11, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32035.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

  8. DrahtBot added the label GUI on Mar 11, 2025
  9. hebasto commented at 5:43 pm on March 11, 2025: member
    Please re-open this PR in https://github.com/bitcoin-core/gui.
  10. hebasto closed this on Mar 11, 2025

  11. VolodymyrBg deleted the branch on Mar 13, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-04-17 09:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me