[Qt] remove unused signal from walletview #3204

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:walletview changing 1 files +1 −2

Diapolo commented at 4:21 PM on November 5, 2013: none

No description provided.
[Qt] remove unused signal from walletview 3b40a0825a
BitcoinPullTester commented at 4:50 PM on November 5, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/3b40a0825a7c7ef01143df7831551dbbde4b58ca for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

in src/qt/walletview.h:None in 3b40a0825a

  98 | @@ -99,9 +99,8 @@ class WalletView : public QStackedWidget
  99 |  
 100 |      /** Re-emit encryption status signal */
 101 |      void updateEncryptionStatus();
 102 | +
 103 |  signals:
 104 | -    /** Signal that we want to show the main window */
 105 | -    void showNormalIfMinimized();

laanwj commented at 4:55 PM on November 5, 2013:

This signal is still being subscribed to in walletframe.

Diapolo commented at 5:11 PM on November 5, 2013:

Thanks for catching... my fault then.

Diapolo commented at 6:24 PM on November 5, 2013: none

Guess it could be good in the future to keep it anyway, closing!
Diapolo closed this on Nov 5, 2013
Diapolo deleted the branch on Nov 5, 2013
laanwj commented at 3:27 PM on November 6, 2013: member

Yes, seems like a useful signal to keep around
Bushstar referenced this in commit 37f96f5a3a on Apr 8, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Diapolo

BitcoinPullTester

laanwj