feature_config_args.py incorrectly assumed that its testnet4 node would not log a disk space warning.
But when #31978 increased m_assumed_blockchain_size on testnet4 from 1 to 11 GiB, it triggered this bug on my RAM disk, see https://github.com/bitcoin/bitcoin/tree/master/test#speed-up-test-runs-with-a-ram-disk
This PR fixes the issue by using -prune which prevents the warning.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32057.
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
utACK c09e2a72ff3b851d4c47d1e715b8bdcc54027364
Change looks good to me.
480+ # Some CI environments will have limited space and some others won't
481+ # so we need to handle both cases as a valid result.
482+ self.nodes[0].stderr.seek(0)
483+ err = self.nodes[0].stdout.read()
484+ self.nodes[0].stderr.seek(0)
485+ self.nodes[0].stderr.truncate()
not sure about logging a warning, then checking it and manually removing it, when the warning isn’t even part of the test. It seems easier to just avoid the warning by setting prune=whatever?
I expect this will make the testnet3 removal diff a tiny bit smaller, as well as the testnet5 addition diff.
feature_config_args.py incorrectly assumed that its testnet4 node
would not log a disk space warning.
0683b8ebf33386d5c05140df89df10b1853d7c7e increased m_assumed_blockchain_size
on testnet4 from 1 to 11 GiB which triggers this bug on more
systems, e.g. a RAM disk.
Prevent the warning by setting -prune for these nodes.
Fix the same issue in feature_signet.py
Implemented @maflcko’s suggestion of using prune to prevent the disk warning rather than deleting it from the log.
I also found the same issue in feature_signet when using the suggested 4 GB instead my usual bigger RAM disk.
You may still occasionally get this failure if you use a too small RAM disk and lots of tests in parallel, but the test suite will warn you:
0There may be insufficient free space in /Volumes/RAMDisk/tmp/test_runner_₿_🏃_20250315_161228 to run the Bitcoin functional test suite.
ACK 20fe41e9e83d510fd467f5a999d55a614b16ef89
Cool, that’s a simpler solution.
ACK 20fe41e9e83d510fd467f5a999d55a614b16ef89
The last statement in the PR description seems to be contradicting with the title & the code comment.
This PR fixes the issue by allowing the space warning on both testnet3 and testnet4.
