test: fix intermittent failure in wallet_reorgsrestore.py #32069

1. 
   furszy commented at 2:36 pm on March 14, 2025: member

   In response to #32066 intermittent failure.

   Wait until the node’s process has fully stopped before starting a new instance of it. Same behavior as in the tool_wallet.py test.

2. 
   DrahtBot commented at 2:36 pm on March 14, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32069.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	maflcko, Chand-ra

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #31250 (wallet: Disable creating and loading legacy wallets by achow101)
   • #28710 (Remove the legacy wallet and BDB dependency by achow101)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

3. DrahtBot added the label Tests on Mar 14, 2025
4. maflcko added this to the milestone 30.0 on Mar 14, 2025
5. 
   maflcko commented at 2:50 pm on March 14, 2025: member

   introduced in 11f8ab140fe63857f6a93b81021efda8f90ceeda, so added 30.0 milestone
6. 
   maflcko commented at 2:52 pm on March 14, 2025: member

   lgtm ACK 0f377b4ef959d5722c02d39d63916233f6e30c64

   Maybe there could be a method on test_node, similar to stop_node to kill the node ?

7. furszy force-pushed on Mar 14, 2025
8. 
   furszy commented at 3:01 pm on March 14, 2025: member

   Maybe there could be a method on test_node, similar to stop_node to kill the node ?

   Done as suggested.

9. DrahtBot added the label CI failed on Mar 14, 2025
10. test: fix intermittent failure in wallet_reorgsrestore.py

    Wait until the node's process has fully stopped before starting a new instance.
    
    Since the same code is used in tool_wallet.py, this consolidates the behavior
    into a 'kill_process()' function.

    36b0713edc
11. 
    DrahtBot commented at 3:06 pm on March 14, 2025: contributor

    🚧 At least one of the CI tasks failed. Debug: https://github.com/bitcoin/bitcoin/runs/38783776230

    Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

    • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

    • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

    • An intermittent issue.

    Leave a comment here, if you need help tracking down a confusing failure.

12. furszy force-pushed on Mar 14, 2025
13. 
    maflcko commented at 3:13 pm on March 14, 2025: member

    lgtm ACK 36b0713edc4655f6e0c291975d6d280fbc89cf2e
14. DrahtBot removed the label CI failed on Mar 14, 2025
15. 
    Chand-ra commented at 1:23 pm on March 16, 2025: none

    tACK 36b0713

    Tested by pulling the PR locally and verifying that the behavior of the changed test (or any other test) doesn’t change with the proposed change.

16. fanquake merged this on Mar 16, 2025
17. fanquake closed this on Mar 16, 2025

    ---

18. furszy deleted the branch on Mar 16, 2025

Contributors
furszy DrahtBot maflcko Chand-ra

Labels
Tests

Milestone
30.0