Continuation of work in #3099.
Keep a list of requested payments in the Receive tab so that a user can recall previously created receive requests after closing their windows.
Currently this list is not stored between bitcoin-qt sessions. This can be implemented later, but it is not clear here it should be stored as I don't think it belongs in the wallet (maybe in QSettings?) at least until it is really associated with a transaction.
Nice work, but I tend to disagree storing in QSettings, as this is at least on Windows stored in the registry. Would be ugly and bad practise to do this IMHO.
I don't see why this would not be stored in the wallet?
EDIT: misread, this is about requested payments - not sent ones.
The wallet stores both "from" and "to" transactions, so storing both "from" and "to" payment requests makes sense to me (I believe we're storing neither right now).
@sipa I guess it could be stored in the wallet, but that means there will need to be a core interface for storing arbitrary data (that the core doesn't know the format of) in the wallet. @gavinandresen Yes, storing incoming payment requests would make sense too, and could be done in a similar way but somewhere else in the UI
@gavinandresen Thinking about it, we should store incoming payment requests in the transaction metadata and simply show them in the transactions list. We can't do the same for outgoing payment requests at least until the recipient pays them, maybe they could be correlated and stored in the transaction list then, but until the request is paid it must be in this separate list.
Keep a list of requested payments in the Receive tab so that a user can
recall previously created requests after closing their windows.
Currently this list is not stored between bitcoin-qt sessions. This can
be implemented later, but it is not clear where it should be stored as
I don't think it belongs in the wallet (maybe in QSettings?)
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/666893b1facfbc748de760e6aeb6bc26bd3797f3 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.