test: switch wallet_crosschain.py to signet and drop testnet4 #32088

1. 
   Sjors commented at 8:30 am on March 18, 2025: member

   It’s sufficient to check only one test network, so this PR reverts the addition of testnet4 from #29775.

   Testnet3 is deprecated. Instead of moving to testnet4, which might also be deprecated in the future, use signet.

2. test: drop testnet4 from wallet_crosschain.py

   This reverts the changes to test/functional/wallet_crosschain.py
   in commit 74a04f9e7ad6a16988149cc3438b9ce13c91cdb9.
   
   It's sufficient to check only one test network. The next commit
   will change that network away from testnet3.

   9c2951541c
3. 
   DrahtBot commented at 8:30 am on March 18, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32088.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	fjahr, maflcko

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #31974 (Drop testnet3 by Sjors)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. DrahtBot added the label Tests on Mar 18, 2025
5. 
   Sjors commented at 8:31 am on March 18, 2025: member

   Suggested by @maflcko in #31974 (review)

   cc @fjahr

6. in test/functional/wallet_crosschain.py:27 in 213abf5f1c outdated

   32-
   33+        # Switch node 1 to signet before starting it.
   34+        self.nodes[1].chain = 'signet'
   35+        # Disable signet sync and prevent disk space warning on low resource CI
   36+        self.nodes[1].extra_args = ['-maxconnections=0', '-prune=550']
   37+        self.nodes[1].replace_in_config([('regtest=', 'signet='), ('[regtest]', '[signet]')])
   

   ---

   ---

   

   maflcko commented at 8:37 am on March 18, 2025:

   0        # Switch node 1 to any network different from regtest before starting it.
   1        self.nodes[1].chain = 'signet'
   2        # Disable network sync and prevent disk space warning on low resource CI
   3        self.nodes[1].extra_args = ['-maxconnections=0', '-prune=550']
   4        self.nodes[1].replace_in_config([('regtest=', 'signet='), ('[regtest]', '[signet]')])
   

   nit in 213abf5f1ce9f0242d83e57f29eb696c9e77e755:

   Could keep it a bit more general to reduce the churn in the future and document that the exact network doesn’t matter.

   ---

   

   Sjors commented at 8:45 am on March 18, 2025:

   Done
7. 
   maflcko commented at 8:37 am on March 18, 2025: member

   Concept ACK
8. test: switch wallet_crosschain.py to signet

   Testnet3 is deprecated. Instead of moving to testnet4, which might
   also be deprecated in the future, use signet.

   cec14ee47d
9. Sjors force-pushed on Mar 18, 2025
10. 
    fjahr commented at 4:52 pm on March 18, 2025: contributor

    utACK cec14ee47d71d8dd5ca8f90b760d807c3c8933a5

    Looks good to me and CI failure seems unrelated.

11. DrahtBot requested review from maflcko on Mar 18, 2025
12. 
    maflcko commented at 5:49 pm on March 18, 2025: member

    lgtm ACK cec14ee47d71d8dd5ca8f90b760d807c3c8933a5 🌰

    Signature:

    0untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
    1RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
    2trusted comment: lgtm ACK cec14ee47d71d8dd5ca8f90b760d807c3c8933a5 🌰
    3iqu9IGhZIYCH5/fECsfNjQWDPcecCY4hNA35+l+ULB7hMy8C0lv2/ixqc+YxXPTgUP6shALuRoVbRIZ3Bf5CCg==
    

13. fanquake merged this on Mar 18, 2025
14. fanquake closed this on Mar 18, 2025

    ---

15. Sjors deleted the branch on Mar 19, 2025

Contributors
Sjors DrahtBot maflcko fjahr

Review Requested
maflcko

Labels
Tests