@laanwj Could you check the AskPassphraseDialog::event() code, it looks like we nearly duplicated AskPassphraseDialog::eventFilter(). Perhaps it's save to remove it, I'm not sure.
[Qt] make event() and eventFilter() in askpassphrasedialog protected #3209
pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:askpass changing 1 files +2 −0-
Diapolo commented at 6:21 PM on November 5, 2013: none
-
[Qt] make event() and eventFilter() in askpassphrasedialog protected a80b1a0312
-
BitcoinPullTester commented at 6:42 PM on November 5, 2013: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/a80b1a03126f3f9101bb150c66cbcaa5f9f20354 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
laanwj commented at 12:53 PM on November 7, 2013: member
It's not duplicated: event() detects a capslock key press in the dialog, whereas the eventFilter (which subscribes to events from the QLineEdits) uses a rough heuristic to detect characters that cannot be produced with/without shift. ACK otherwise
- laanwj referenced this in commit b744fdbf52 on Nov 7, 2013
- laanwj merged this on Nov 7, 2013
- laanwj closed this on Nov 7, 2013
- Diapolo deleted the branch on Nov 8, 2013
- Bushstar referenced this in commit 203cc90778 on Apr 8, 2020
- Bushstar referenced this in commit a69851325e on Apr 8, 2020
- DrahtBot locked this on Sep 8, 2021
Contributors