wallet, rpc: remove settxfee and paytxfee #32138

1. 
   polespinasa commented at 6:30 pm on March 25, 2025: contributor

   Summary

   This PR removes the settxfee RPC and paytxfee setting (Bitcoin Core 31.0). These two features were deprecated in #31278.

   This PR does not remove the internal implementation of the default value of paytxfee=0 but removes the option for users to modify it.

2. 
   DrahtBot commented at 6:30 pm on March 25, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32138.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #32139 (test: remove strict restrictions on rpc_deprecated test by polespinasa)
   • #31896 (refactor: Remove redundant and confusing calls to IsArgSet by maflcko)
   • #29278 (Wallet: Add maxfeerate wallet startup option by ismaelsadeeq)
   • #25722 (refactor: Use util::Result class for wallet loading by ryanofsky)
   • #19461 (multiprocess: Add bitcoin-gui -ipcconnect option by ryanofsky)
   • #19460 (multiprocess: Add bitcoin-wallet -ipcconnect option by ryanofsky)
   • #10102 (Multiprocess bitcoin by ryanofsky)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

3. DrahtBot added the label CI failed on Mar 25, 2025
4. 
   DrahtBot commented at 6:43 pm on March 25, 2025: contributor

   🚧 At least one of the CI tasks failed. Debug: https://github.com/bitcoin/bitcoin/runs/39393296960

   Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

   • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

   • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

   • An intermittent issue.

   Leave a comment here, if you need help tracking down a confusing failure.

5. DrahtBot added this to the milestone 31.0 on Mar 25, 2025
6. DrahtBot marked this as a draft on Mar 25, 2025
7. remove settxfee and paytxfee d89487370a
8. polespinasa force-pushed on Mar 25, 2025
9. polespinasa renamed this:
   wallet, rpc: (v31.0) remove settxfee and paytxfee (work in progress)
   wallet, rpc: (v31.0) remove settxfee and paytxfee
   on Mar 25, 2025
10. polespinasa marked this as ready for review on Mar 25, 2025
11. 
    polespinasa commented at 6:56 pm on March 25, 2025: contributor

    Note to self: re-check all tests
12. 
    maflcko commented at 7:10 pm on March 25, 2025: member

    Please leave this in draft. 31.0 is half a year out, so starting review on this is questionable and won’t help to get it merged earlier anyway
13. polespinasa renamed this:
    wallet, rpc: (v31.0) remove settxfee and paytxfee
    wallet, rpc: (v31.0) remove settxfee and paytxfee (work in progress)
    on Mar 25, 2025
14. polespinasa marked this as a draft on Mar 25, 2025
15. DrahtBot removed the label CI failed on Mar 25, 2025
16. fanquake renamed this:
    wallet, rpc: (v31.0) remove settxfee and paytxfee (work in progress)
    wallet, rpc: remove settxfee and paytxfee
    on Mar 26, 2025
17. laanwj added the label Wallet on Mar 26, 2025
18. laanwj added the label RPC/REST/ZMQ on Mar 26, 2025
19. 
    DrahtBot commented at 9:51 am on March 27, 2025: contributor

    🐙 This pull request conflicts with the target branch and needs rebase.

20. DrahtBot added the label Needs rebase on Mar 27, 2025

Contributors
polespinasa DrahtBot maflcko

Labels
Wallet RPC/REST/ZMQ Needs rebase

Milestone
31.0