wallet, rpc: remove settxfee and paytxfee

polespinasa commented at 6:30 pm on March 25, 2025: member

Summary

This PR removes the settxfee RPC and paytxfee setting (Bitcoin Core 31.0). These two features were deprecated in #31278.

DrahtBot commented at 6:30 pm on March 25, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32138.

Reviews

See the guideline for information on the review process.

Type	Reviewers
Concept ACK	theStack

If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#34075 (fees: Introduce Mempool Based Fee Estimation to reduce overestimation by ismaelsadeeq)
#34049 (rpc: Disallow captures in RPCMethodImpl by ajtowns)
#32636 (Split CWallet::Create() into CreateNew and LoadExisting by davidgumberg)
#29278 (Wallet: Add maxfeerate wallet startup option by ismaelsadeeq)
#19461 (multiprocess: Add bitcoin-gui -ipcconnect option by ryanofsky)
#19460 (multiprocess: Add bitcoin-wallet -ipcconnect option by ryanofsky)
#17783 (common: Disallow calling IsArgSet() on ALLOW_LIST options by ryanofsky)
#17581 (refactor: Remove settings merge reverse precedence code by ryanofsky)
#17580 (refactor: Add ALLOW_LIST flags and enforce usage in CheckArgFlags by ryanofsky)
#17493 (util: Forbid ambiguous multiple assignments in config file by ryanofsky)
#10102 (Multiprocess bitcoin by ryanofsky)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

LLM Linter (✨ experimental)

Possible typos and grammar issues:

deprected -> deprecated [spelling error in release notes; “deprected” should be “deprecated”]

Possible places where named args for integral literals may be used (e.g. func(x, /*named_arg=*/0) in C++, and func(x, named_arg=0) in Python):

self.nodes[2].sendtoaddress(address, 10, “”, “”, False, fee_rate=fee_rate_sat_vb) in test/functional/wallet_basic.py
self.nodes[2].sendtoaddress(address, 10, “”, “”, True, fee_rate=fee_rate_sat_vb) in test/functional/wallet_basic.py
self.nodes[2].sendmany(’’, {address: 10}, 0, “”, [], fee_rate=fee_rate_sat_vb) in test/functional/wallet_basic.py
self.nodes[2].sendmany(’’, {address: 10}, 0, “”, [address], fee_rate=fee_rate_sat_vb) in test/functional/wallet_basic.py

2026-01-07

DrahtBot added the label CI failed on Mar 25, 2025

DrahtBot commented at 6:43 pm on March 25, 2025: contributor

🚧 At least one of the CI tasks failed. Debug: https://github.com/bitcoin/bitcoin/runs/39393296960

Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.
A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.
An intermittent issue.

Leave a comment here, if you need help tracking down a confusing failure.

DrahtBot added this to the milestone 31.0 on Mar 25, 2025

DrahtBot marked this as a draft on Mar 25, 2025

polespinasa force-pushed on Mar 25, 2025

polespinasa renamed this:
~~wallet, rpc: (v31.0) remove settxfee and paytxfee (work in progress)~~
wallet, rpc: (v31.0) remove settxfee and paytxfee
on Mar 25, 2025

polespinasa marked this as ready for review on Mar 25, 2025

polespinasa commented at 6:56 pm on March 25, 2025: member

Note to self: re-check all tests

maflcko commented at 7:10 pm on March 25, 2025: member

Please leave this in draft. 31.0 is half a year out, so starting review on this is questionable and won’t help to get it merged earlier anyway

polespinasa renamed this:
~~wallet, rpc: (v31.0) remove settxfee and paytxfee~~
wallet, rpc: (v31.0) remove settxfee and paytxfee (work in progress)
on Mar 25, 2025

polespinasa marked this as a draft on Mar 25, 2025

DrahtBot removed the label CI failed on Mar 25, 2025

fanquake renamed this:
~~wallet, rpc: (v31.0) remove settxfee and paytxfee (work in progress)~~
wallet, rpc: remove settxfee and paytxfee
on Mar 26, 2025

laanwj added the label Wallet on Mar 26, 2025

laanwj added the label RPC/REST/ZMQ on Mar 26, 2025

DrahtBot added the label Needs rebase on Mar 27, 2025

polespinasa commented at 7:25 am on June 24, 2025: member

Will re-open closer to 31.0 release

polespinasa closed this on Jun 24, 2025

maflcko commented at 11:18 am on August 26, 2025: member

Seems fine to pick this up now, if you want.

polespinasa reopened this on Aug 26, 2025

polespinasa force-pushed on Aug 26, 2025

polespinasa marked this as ready for review on Aug 26, 2025

DrahtBot removed the label Needs rebase on Aug 26, 2025

polespinasa force-pushed on Aug 26, 2025

polespinasa commented at 6:08 pm on August 26, 2025: member

5ba260ca74 Rebased on top of master 6ca6f3b37b

polespinasa force-pushed on Aug 26, 2025

DrahtBot added the label CI failed on Aug 26, 2025

DrahtBot commented at 6:11 pm on August 26, 2025: contributor

🚧 At least one of the CI tasks failed. Task lint: https://github.com/bitcoin/bitcoin/runs/48937774714 LLM reason (✨ experimental): Lint failure caused by an invalid Python shebang in test/functional/wallet_txn_clone.py (syntax error).

Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.
A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.
An intermittent issue.

Leave a comment here, if you need help tracking down a confusing failure.

DrahtBot removed the label CI failed on Aug 26, 2025

maflcko commented at 8:48 am on August 28, 2025: member

What is the point of keeping m_pay_tx_fee. It is just dead code now, no?

polespinasa commented at 6:17 pm on August 28, 2025: member

It is just dead code now, no? @maflcko I think you’re right. Will squash after review, think it’s easier this way.

in src/wallet/wallet.h:105 in d3ed01fbc8 outdated

101@@ -102,7 +102,7 @@ void NotifyWalletLoaded(WalletContext& context, const std::shared_ptr<CWallet>&
102 std::unique_ptr<WalletDatabase> MakeWalletDatabase(const std::string& name, const DatabaseOptions& options, DatabaseStatus& status, bilingual_str& error);
103 
104 //! -paytxfee default (paytxfee RPC was removed in v31.0)
105-constexpr CAmount DEFAULT_PAY_TX_FEE = 0;
106+//constexpr CAmount DEFAULT_PAY_TX_FEE = 0;

polespinasa commented at 6:25 pm on August 28, 2025:

forgot to remove the line, will do next push

maflcko commented at 2:43 pm on September 1, 2025: member

Will squash after review, think it’s easier this way.

I’d say to either squash now, or create meaningful separate commits. E.g:

First, remove from rpc (settxfee, paytxfee result)
Then, remove from cli (-paytxfee, tests only)
Then, remove from cli (-paytxfee, code, and remaining leftovers)

wallet, rpc:remove settxfee and paytxfee f0dc25a228

polespinasa force-pushed on Sep 2, 2025

theStack commented at 2:27 pm on January 5, 2026: contributor

Concept ACK

This should have a release note, and IIUC, the following part of the PR description doesn’t apply anymore:

This PR does not remove the internal implementation of the default value of paytxfee=0 but removes the option for users to modify it.

fanquake added the label Needs release note on Jan 5, 2026

release note 76a5e97671

wallet, rpc: remove settxfee and paytxfee #32138

Code Coverage & Benchmarks

Reviews

Conflicts

LLM Linter (✨ experimental)