lint: Remove needless borrow to fix Clippy warning #32144

pull strmfos wants to merge 1 commits into bitcoin:master from strmfos:master changing 1 files +1 −1
  1. strmfos commented at 7:09 am on March 26, 2025: contributor

    Pull Request Description

    Summary Removes a needless borrow in test/lint/test_runner/src/main.rs that triggered a Clippy warning (needless_borrows_for_generic_args). This minor refactoring makes the code cleaner without changing functionality.

    Rationale

    • Eliminates a Clippy warning when running:
      0cargo clippy --manifest-path test/lint/test_runner/Cargo.toml -- -D warnings
      
  2. Remove needless borrow to fix Clippy warning e3ce2bd982
  3. DrahtBot commented at 7:09 am on March 26, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32144.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK maflcko, TheCharlatan, kevkevinpal

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. strmfos commented at 7:10 am on March 26, 2025: contributor

    Summary Removes a needless borrow in test/lint/test_runner/src/main.rs that triggered a Clippy warning (needless_borrows_for_generic_args). This minor refactoring makes the code cleaner without changing functionality.

    Rationale

    • Eliminates a Clippy warning when running:
      0cargo clippy --manifest-path test/lint/test_runner/Cargo.toml -- -D warnings
      
  5. DrahtBot renamed this:
    Remove needless borrow to fix Clippy warning
    lint: Remove needless borrow to fix Clippy warning
    on Mar 26, 2025
  6. DrahtBot added the label Tests on Mar 26, 2025
  7. maflcko commented at 7:34 am on March 26, 2025: member
    lgtm ACK e3ce2bd9829bbe14e5da26505ac9d68ae0d2af2d
  8. TheCharlatan approved
  9. TheCharlatan commented at 9:08 am on March 26, 2025: contributor
    ACK e3ce2bd9829bbe14e5da26505ac9d68ae0d2af2d
  10. kevkevinpal commented at 4:32 pm on March 26, 2025: contributor

    ACK e3ce2bd

    lgtm, you might want to put that summary comment in the PR description since most would look there first to get a summary of the change

  11. strmfos commented at 8:01 pm on March 26, 2025: contributor
    done , thank you
  12. fanquake merged this on Mar 27, 2025
  13. fanquake closed this on Mar 27, 2025


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-04-16 18:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me