test: fix intermittent timeout in p2p_ibd_stalling.py #32148

pull mzumsande wants to merge 1 commits into bitcoin:master from mzumsande:202503_fix_ibd_stalling changing 1 files +1 −1
  1. mzumsande commented at 5:32 pm on March 26, 2025: contributor

    After sending the headers message add a sync, so that we wait until the header message from the previous peer has been received before connecting additional peers. In the failed NetBSD run linked in #32090, the second node managed to complete the handshake and send its own headers message before the message from the first node was received.

    Fixes #32090

  2. test: fix intermittent timeout in p2p_ibd_stalling.py
    by adding a sync, so that we wait until the header message from the
    previous peer has been received before connecting additional peers.
    9f35d4d070
  3. DrahtBot commented at 5:32 pm on March 26, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32148.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK maflcko

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Tests on Mar 26, 2025
  5. maflcko commented at 7:14 am on March 27, 2025: member
    lgtm ACK 9f35d4d070b2097259c0bfada391d8ef847e256e
  6. maflcko added this to the milestone 29.0 on Mar 27, 2025
  7. maflcko added the label Needs backport (29.x) on Mar 27, 2025
  8. maflcko removed the label Needs backport (29.x) on Mar 27, 2025
  9. maflcko removed this from the milestone 29.0 on Mar 27, 2025
  10. maflcko commented at 7:15 am on March 27, 2025: member
    (This is not a clean backport and should be rare enough to not matter, so can probably skip the backport here)
  11. fanquake merged this on Mar 27, 2025
  12. fanquake closed this on Mar 27, 2025

  13. mzumsande deleted the branch on Mar 27, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-04-01 06:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me