qt: add Open URI dialog #3215

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2013_11_openuridialog changing 11 files +289 −19

laanwj commented at 2:17 PM on November 6, 2013: member
This adds a simple "Open URI..." option to the menu which allows manually opening URIs and payment requests from files on disk.

Some behind-the-scenes code changes:
- Always route received URIs (even those drag/dropped) through PaymentServer; this means that bitcoin: URIs that refer to payment requests can be used
- Add getOpenFileName function to GUIUtil analogous to getSaveFileName
Addresses #3202.

in src/qt/forms/openuridialog.ui:None in fd92fafeab outdated

   9 | +    <width>564</width>
  10 | +    <height>109</height>
  11 | +   </rect>
  12 | +  </property>
  13 | +  <property name="windowTitle">
  14 | +   <string>Open URI...</string>

Diapolo commented at 6:59 AM on November 8, 2013:

There should be no ellipsis here.

laanwj commented at 7:56 AM on November 8, 2013:

Agreed

in src/qt/openuridialog.cpp:None in fd92fafeab outdated
```
  19 | +OpenURIDialog::~OpenURIDialog()
  20 | +{
  21 | +    delete ui;
  22 | +}
  23 | +
  24 | +QString OpenURIDialog::URI()
```
Diapolo commented at 7:01 AM on November 8, 2013:

I would rather call this getUri().

laanwj commented at 7:54 AM on November 8, 2013:

I don't agree with the capitalization. We use URI in uppercase in the interface everywhere: parseBitcoinURI, formatBitcoinURI, handleURIConnection, ... Uri is used nowhere at all.

As for getURI() / URI(), meh, Qt itself doesn't add get for properties either. Example: QLineEdit text() / setText(). But we do it in other places in the gui. Fine with me really.

Diapolo commented at 7:56 AM on November 8, 2013:

No need to argue, I'm fine with what you say :).

in src/qt/openuridialog.cpp:None in fd92fafeab outdated

  38 | +    }
  39 | +}
  40 | +
  41 | +void OpenURIDialog::on_selectFileButton_clicked()
  42 | +{
  43 | +    QString filename = GUIUtil::getOpenFileName(this, tr("Select payment request to open"), "", "", NULL);

Diapolo commented at 7:02 AM on November 8, 2013:

Is payment request file better here?

in src/qt/openuridialog.cpp:None in fd92fafeab outdated
```
   0 | @@ -0,0 +1,48 @@
   1 | +#include "openuridialog.h"
```
Diapolo commented at 7:03 AM on November 8, 2013:

Your new files are missing the license header :-P.
BitcoinPullTester commented at 1:29 PM on November 11, 2013: none

Automatic sanity-testing: FAILED MERGE, see http://jenkins.bluematt.me/pull-tester/62d718ee350d4a2abfb31f8ea0c2af40b4abcbb7 for test log.

This pull does not merge cleanly onto current master This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
qt: add Open URI dialog 4c60358604
laanwj referenced this in commit c2468c1542 on Nov 11, 2013
laanwj merged this on Nov 11, 2013
laanwj closed this on Nov 11, 2013
laanwj deleted the branch on Apr 9, 2014
DrahtBot locked this on Sep 8, 2021

Contributors

laanwj

Diapolo

BitcoinPullTester

Linked (view graph)

#3202 Add a way to enter a bitcoin URI in GUI