Consensus code without testing #32156

issue 1440000bytes opened this issue on March 27, 2025
  1. 1440000bytes commented at 9:35 PM on March 27, 2025: none

    #32155

    This pull request is not discussed, reviewed, tested etc. enough to be merged in core.

    I cannot comment in #32155 because they have blocked me on GitHub.

  2. sipa commented at 9:49 PM on March 27, 2025: member

    That PR is not a consensus change.

  3. maflcko commented at 9:49 PM on March 27, 2025: member

    The pull request was opened two hours ago. It would be surprising if anyone looked at it, let alone review and test. So it not being reviewed/tested/merged is normal and expected and there is no need to open an issue about it.

  4. maflcko closed this on Mar 27, 2025

  5. 1440000bytes commented at 9:57 PM on March 27, 2025: none

    It would be surprising if anyone looked at it, let alone review and test. So it not being reviewed/tested/merged is normal and expected and there is no need to open an issue about it.

    I am the only bitcoin core contributor who cannot comment in the pull request. So it makes sense for me to create a new issue.

    I might do it in future as well.

  6. l0rinc commented at 10:08 PM on March 27, 2025: contributor

    I might do it in future as well

    Try finding a way that isn't so hostile, not everything's an attack...

  7. 1440000bytes commented at 10:16 PM on March 27, 2025: none

    Sorry @sipa @maflcko

  8. Sjors commented at 9:34 AM on March 28, 2025: member

    @1440000bytes hopefully I've addressed some of your concerns here: #32155 (comment)

    I'll keep an eye on this thread as well.


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-15 15:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me