[Qt] rename rpcconsole window #3222

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:debug-window changing 3 files +4 −9

Diapolo commented at 7:27 AM on November 8, 2013: none
- rework window title to not include Bitcoin - in front, as no other dialog does this
- favor a connect() call over an own function for clearing the traffic graph
- write monospace lowercase (seems to be correct after some web search) and add a comment that we should avoid / remove fixed font sizes

[Qt] rename rpcconsole window

- rework window title to not include Bitcoin - in front, as no other
  dialog does this
- favor a connect() call over an own function for clearing the traffic
  graph
- write monospace lowercase (seems to be correct after some web search)
  and add a comment that we should avoid / remove fixed font sizes

91163c15f6

in src/qt/rpcconsole.cpp:None in 430aa6d043 outdated
```
 281 | @@ -280,7 +282,7 @@ void RPCConsole::setClientModel(ClientModel *model)
 282 |          ui->buildDate->setText(model->formatBuildDate());
 283 |          ui->startupTime->setText(model->formatClientStartupTime());
 284 |  
 285 | -        ui->isTestNet->setChecked(model->isTestNet());
 286 | +        ui->isTestNet->setChecked(TestNet());
```
laanwj commented at 8:12 AM on November 8, 2013:

I still prefer querying things about the client through the model instead of using a global function call. Call me old-fashioned, but that's how I designed it initially.

Diapolo commented at 8:20 AM on November 8, 2013:

Understood, perhaps one day we could audit the code and see what Qt code parts break with this or general client model usage and re-work them?

laanwj commented at 8:31 AM on November 8, 2013:

That day will come when we want to run the GUI and wallet and RPC client in separate processes with separate permissions. For new code I'm not very strict about it, but let's not make the old code break it too. Less core includes in general GUI files = better.

in src/qt/rpcconsole.cpp:None in 430aa6d043 outdated

 205 | @@ -205,6 +206,7 @@ void RPCExecutor::request(const QString &command)
 206 |      ui->messagesWidget->installEventFilter(this);
 207 |  
 208 |      connect(ui->clearButton, SIGNAL(clicked()), this, SLOT(clear()));
 209 | +    connect(ui->btnClearTrafficGraph, SIGNAL(clicked()), ui->trafficGraph, SLOT(clear()));

laanwj commented at 8:13 AM on November 8, 2013:

ACK on this change, nice find

laanwj referenced this in commit 7f0ccea768 on Nov 8, 2013
laanwj merged this on Nov 8, 2013
laanwj closed this on Nov 8, 2013
Diapolo deleted the branch on Nov 8, 2013
BitcoinPullTester commented at 8:36 AM on November 8, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/91163c15f64e5bbf75e41defb721ba4a5e3b412b for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
Bushstar referenced this in commit 08f447af92 on Apr 8, 2020
Bushstar referenced this in commit 5213118601 on Apr 8, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Diapolo

laanwj

BitcoinPullTester