doc: better document NetEventsInterface and the deletion of “CNode"s #32278

1. 
   vasild commented at 4:06 pm on April 15, 2025: contributor

   Document the requirements around the NetEventsInterface’s methods and the lifetime of CNode objects in CConnman::m_nodes.
2. 
   DrahtBot commented at 4:06 pm on April 15, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32278.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	w0xlt

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #32015 (net: replace manual reference counting of CNode with shared_ptr by vasild)
   • #30988 (Split CConnman by vasild)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

3. DrahtBot added the label Docs on Apr 15, 2025
4. vasild force-pushed on Apr 16, 2025
5. vasild force-pushed on Apr 16, 2025
6. doc: better document NetEventsInterface and the deletion of "CNode"s

   Document the requirements around the `NetEventsInterface`'s methods and
   the lifetime of `CNode` objects in `CConnman::m_nodes`.

   e44e669378
7. 
   vasild commented at 4:16 am on April 16, 2025: contributor

   1091faf8ff...0f26ac35e2 and 0f26ac35e2...e44e669378: further elaborate how we safely access CNodes in m_nodes and how we avoid CNode destruction while it is being referenced.
8. 
   w0xlt commented at 5:52 pm on April 17, 2025: contributor

   ACK https://github.com/bitcoin/bitcoin/pull/32278/commits/e44e669378f2c63b09eda68797039b73047febff

   Clear improvement in documentation.

Contributors
vasild DrahtBot w0xlt

Labels
Docs