test: cover invalid codesep positions for signature in taproot #32301
pull instagibbs wants to merge 1 commits into bitcoin:master from instagibbs:2025-04-codesep_cov changing 2 files +4 −2-
instagibbs commented at 8:18 pm on April 17, 2025: memberThere is some basic coverage, but I felt like adding some boundary conditions where the only issue is the codesep value would be nice.
-
DrahtBot commented at 8:18 pm on April 17, 2025: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32301.
Reviews
See the guideline for information on the review process.
Type Reviewers Stale ACK sipa If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #32473 (Introduce per-txin sighash midstate cache for legacy/p2sh/segwitv0 scripts by sipa)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
DrahtBot added the label Tests on Apr 17, 2025
-
sipa commented at 9:51 pm on April 17, 2025: memberACK 175740991e0081c35f471cd7f1ad067e3e1f978f
-
fanquake requested review from ajtowns on Apr 25, 2025
-
DrahtBot added the label Needs rebase on May 6, 2025
-
instagibbs force-pushed on May 30, 2025
-
test: cover invalid codesep positions for signature in taproot 89646cbd82
-
instagibbs force-pushed on May 30, 2025
-
bitcoin deleted a comment on May 30, 2025
-
instagibbs commented at 2:11 pm on May 30, 2025: memberrebased due to merge conflict
-
DrahtBot removed the label Needs rebase on May 30, 2025
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-06-15 09:13 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-06-15 09:13 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me