Remove Wallet Tools #3234

pull super3 wants to merge 1 commits into bitcoin:master from super3:master changing 5 files +10 −17

super3 commented at 1:49 PM on November 11, 2013: contributor

We already have the exact same funtionality in /contrib/bitrpc/bitrpc.py

If we really do need standalone scripts, then I'll write something to pull it from that file, rather than having duplicate code.
Diapolo commented at 10:01 PM on November 11, 2013: none

If wallettools folder is empty, that should also be removed, didn't look into it ^^.
super3 commented at 11:47 PM on November 11, 2013: contributor

I believe it has, or at least in my repo it is.
laanwj commented at 7:56 AM on November 12, 2013: member
I'm fine with removing them.

Indeed, bitrpc.py provides the same functionality with regard to walletpassphrase / walletpassphrasechange.
```
            pwd = raw_input("Enter wallet passphrase: ")
            access.walletpassphrase(pwd, 60)
```
IMO what would be nice functionality is parsing rpcuser/rpcpass from the bitcoin.conf like bitcoind/bitcoin-cli does, instead of asking for it every time or having to put it in the script. In any case that's not related to this issue :)
super3 commented at 8:03 AM on November 12, 2013: contributor

@laanwj Noted. Will take a look at that when I throw in my bitrpc changes.
laanwj commented at 3:44 PM on November 13, 2013: member

I wonder how many people are using these utilities actively, and if they know they can use bitrpc.py for the same.

I find only one mention of the utilities in a 2011 topic on bitcointalk, by Gavin: https://bitcointalk.org/index.php?topic=54671.10

See also issue #2318
super3 commented at 8:45 PM on November 13, 2013: contributor

To avoid any confusion, I will add this info to the README in the next commit.

On Wed, Nov 13, 2013 at 10:44 AM, Wladimir J. van der Laan < notifications@github.com> wrote:

I wonder how many people are using these utilities actively, and if they know they can use bitrpc.py for the same.

I find only one mention of the utilities in a 2011 topic on bitcointalk, by Gavin: https://bitcointalk.org/index.php?topic=54671.10

— Reply to this email directly or view it on GitHubhttps://github.com/bitcoin/bitcoin/pull/3234#issuecomment-28405174 .

Shawn Wilkinson Student, Morehouse College Bitcoin Developer/Entrepreneur/Enthusiast (1P4QkLsujBPBZyUwDezikL4fUSs7JvFhPv) me@super3.org http://super3.org
super3 commented at 3:33 PM on November 15, 2013: contributor

@laanwj Fixed. Have explicit instructions to use bitrpc.

Remove Wallet Tools

We already have the exact same funtionality in /contrib/bitrpc/bitrpc.py

If we really do need standalone scripts, then I'll write something to
pull it from that file, rather than having duplicate code.

Forgot to remove wallet tools from index.

Wallet Tools Follow Up Info

43bba5d012

BitcoinPullTester commented at 6:06 PM on November 15, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/43bba5d012eb770eb32699fa1cbbab3498d6db40 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj referenced this in commit 96aaf006a5 on Nov 19, 2013
laanwj merged this on Nov 19, 2013
laanwj closed this on Nov 19, 2013
Bushstar referenced this in commit dad102669b on Apr 8, 2020
DrahtBot locked this on Sep 8, 2021

Contributors