Introduce disable-wallet / no-wallet mode (rebased) #3240

pull laanwj wants to merge 3 commits into bitcoin:master from laanwj:2013_11_rebase_no_wallet changing 6 files +177 −123

laanwj commented at 12:44 PM on November 12, 2013: member

Rebased version of #2901 @wtogami
init.cpp: cosmetic indent changes, preparing for no-wallet mode f9ee7a032b

in src/init.cpp:None in 5243d28c18 outdated

 900 | @@ -898,92 +901,97 @@ bool AppInit2(boost::thread_group& threadGroup, bool fForceServer)
 901 |  
 902 |      // ********************************************************* Step 8: load wallet
 903 |  
 904 | -    uiInterface.InitMessage(_("Loading wallet..."));
 905 | +    if (fDisableWallet) {
 906 | +        uiInterface.InitMessage(_("Wallet disabled..."));

sipa commented at 1:10 PM on November 12, 2013:

Same pet peeve as before: don't use '...' if it's not an ongoing operation.

laanwj commented at 1:14 PM on November 12, 2013:

Right, agreed. Does it make sense to have a progress message at all if there is no ongoing operation?

laanwj commented at 1:26 PM on November 12, 2013: member

Removed the faux progress message.

I also want to get the GUI working in a limited way (or if not possible, at least non-crashing).
laanwj commented at 1:56 PM on November 12, 2013: member

Voila

Yes, I know the window title still has "Wallet" in it, but apart from that nothing wallet-related is shown and all wallet-related actions and menu options are disabled (which means that apart from Quit and About and such only the Options and Debug Console commands are active, but those could be useful... :pizza:)
in src/init.cpp:None in 8121047b20 outdated
```
 900 | @@ -898,92 +901,96 @@ bool AppInit2(boost::thread_group& threadGroup, bool fForceServer)
 901 |  
 902 |      // ********************************************************* Step 8: load wallet
 903 |  
 904 | -    uiInterface.InitMessage(_("Loading wallet..."));
 905 | +    if (fDisableWallet) {
 906 | +        pwalletMain = NULL;
```
wtogami commented at 12:40 AM on November 13, 2013:

Please re-add the print so debug.log can be informative?

uiInterface.InitMessage(_("Wallet disabled!"));

wtogami commented at 12:41 AM on November 13, 2013:

Note it is ! not ...

laanwj commented at 8:00 AM on November 13, 2013:

I'm fine with adding a debug print that mentions that no wallet is being loaded, but InitMessages are there to show initialization progress in the GUI so if no work is being done it must not be an InitMessage.

Edit: added a normal debug message
wtogami commented at 6:17 AM on November 13, 2013: contributor

https://github.com/litecoin-project/bitcoinomg/tree/bitcoin-0.8.5-OMG4 Disable Wallet for Bitcoin 0.8.5.

https://github.com/litecoin-project/bitcoinomg/commit/f937ef838bf34d083b73564543a4951f1db17eb9 Backported the -disablewallet GUI support.
Add -disablewallet option, to disable wallet support (and BDB) e6b7e3dc79
qt: GUI support for -disablewallet mode 146ba964e4
BitcoinPullTester commented at 8:57 AM on November 13, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/146ba964e4b784171c29600e959a0fae3e2e0c03 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj referenced this in commit 2830a9051d on Nov 13, 2013
laanwj merged this on Nov 13, 2013
laanwj closed this on Nov 13, 2013
jgarzik commented at 1:07 PM on November 13, 2013: contributor

Thanks for pushing this over the finish line. I just got back into the office from family stuff.
laanwj deleted the branch on Apr 9, 2014
Bushstar referenced this in commit 416d85b294 on Apr 8, 2020
Bushstar referenced this in commit c87e825d6f on Apr 8, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Linked (view graph)

#2901 Introduce disable-wallet / no-wallet mode.