wallet, rpc: Change OutputType items from string into compile-time constants string_view #32432

pull w0xlt wants to merge 1 commits into bitcoin:master from w0xlt:outputtype_const changing 5 files +123 −48
  1. w0xlt commented at 2:27 am on May 7, 2025: contributor

    Follow-up to #32429, built on top of it.

    This PR addresses the #32429 (review) that the RPC documentation does not use OUTPUT_TYPES, but rather hardcodes them, as is already the case for the getnewaddress command. So here the output types are changed from std::string to std::string_view so that the values are known at compile time or during the early stages of program startup, before main() execution.

    It also updates wallet/rpc/addresses.cpp to write the RPC docs according to OUTPUT_TYPES instead of using hardcoded version.

  2. DrahtBot commented at 2:28 am on May 7, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32432.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

  3. w0xlt force-pushed on May 7, 2025
  4. DrahtBot added the label CI failed on May 7, 2025
  5. DrahtBot commented at 2:41 am on May 7, 2025: contributor

    🚧 At least one of the CI tasks failed. Task ARM, unit tests, no functional tests: https://github.com/bitcoin/bitcoin/runs/41767168365 LLM reason (✨ experimental): The CI failure is due to a “/*” within a comment, which is treated as an error.

    Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

    • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

    • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

    • An intermittent issue.

    Leave a comment here, if you need help tracking down a confusing failure.

  6. w0xlt force-pushed on May 7, 2025
  7. DrahtBot removed the label CI failed on May 7, 2025
  8. laanwj added the label Wallet on May 7, 2025
  9. laanwj added the label RPC/REST/ZMQ on May 7, 2025
  10. DrahtBot added the label Needs rebase on May 7, 2025
  11. wallet: Map `OutputType` to string into compile-time constants 2fee8f4886
  12. w0xlt force-pushed on May 8, 2025
  13. DrahtBot removed the label Needs rebase on May 8, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-05-08 09:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me