refactor: Removals after bdb removal #32438

1. 
   maflcko commented at 3:29 pm on May 7, 2025: member

   This deletes some dead code
2. vcpkg: Remove bdb fa6a4955ba
3. remove dead flush()

   It is confusing that the chain client flush happens between
   StopHTTPServer and StopMapPort. Also, it is unused code. Seems best to
   just add it back properly when it is needed again.

   fa91ff2b5c
4. remove NotifyWatchonlyChanged

   The signal is never called.

   fa69dd35dc
5. test: remove unused extra_args

   bdb was removed

   fadaa8baaf
6. 
   DrahtBot commented at 3:29 pm on May 7, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32438.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   Approach ACK	w0xlt

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #32345 (ipc: Handle unclean shutdowns better by ryanofsky)
   • #30221 (wallet: Ensure best block matches wallet scan state by achow101)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

7. DrahtBot added the label Refactoring on May 7, 2025
8. Remove unused LegacyDataSPKM::DeleteRecords() faa7c42984
9. doc: fix typo in abortrescan rpc fade93d074
10. doc: Remove note about bdb wallets fada8ea664
11. Remove unused IsSingleKey face91c0a1
12. maflcko force-pushed on May 7, 2025
13. 
    maflcko commented at 3:48 pm on May 7, 2025: member

    There are still some potential follow-ups for someone else:

    0git grep  -i 'legacy wallet' src/bitcoin-wallet.cpp src/wallet src/script/
    

    As well as assert_is_bdb in test/functional/tool_wallet.py.

    Also, (labelWatch* and fHaveWatch*) for the gui people.

14. Remove create options from wallet tool

    Just create descriptor wallets.

    fa23a6f75e
15. maflcko force-pushed on May 7, 2025
16. 
    pablomartin4btc commented at 5:27 pm on May 7, 2025: member

    maybe also this one:

    https://github.com/bitcoin/bitcoin/blob/fa23a6f75ee69abb626b6dec19dbb5a05f457de0/src/wallet/wallet.cpp#L385-L389

    this one:

    https://github.com/bitcoin/bitcoin/blob/fa23a6f75ee69abb626b6dec19dbb5a05f457de0/src/wallet/wallet.cpp#L480-L483

    and this one:

    https://github.com/bitcoin/bitcoin/blob/fa23a6f75ee69abb626b6dec19dbb5a05f457de0/src/wallet/wallet.cpp#L290-L293

17. 
    w0xlt commented at 6:07 pm on May 7, 2025: contributor

    Approach ACK
18. in test/functional/wallet_migration.py:43 in fadaa8baaf outdated

    39@@ -40,7 +40,6 @@ def set_test_params(self):
    40         self.setup_clean_chain = True
    41         self.num_nodes = 2
    42         self.supports_cli = False
    43-        self.extra_args = [[], ["-deprecatedrpc=create_bdb"]]
    

    ---

    ---

    

    achow101 commented at 6:49 pm on May 7, 2025:

    In fadaa8baafc27fbe29721300569e58777643bb1f “test: remove unused extra_args”

    These args are used as the 28.0 node used in this test needs them to make the legacy wallets for testing.

19. achow101 referenced this in commit 1b1b9f32cf on May 7, 2025
20. DrahtBot added the label CI failed on May 7, 2025

Contributors
maflcko DrahtBot pablomartin4btc w0xlt achow101

Labels
Refactoring CI failed