[Qt] make most Windows appear centered on main GUI #3255

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:UI-windows changing 11 files +31 −26

Diapolo commented at 6:56 PM on November 14, 2013: none
- remove default value for parent variable in dialogs, which should appear centered over main GUI and pass appropriate value
- add some addition NULL pointer checks

[Qt] make most Windows appear centered on main GUI

- remove default value for parent variable in dialogs, which should appear
  centered over main GUI and pass appropriate value
- add some addition NULL pointer checks

309f796b39

BitcoinPullTester commented at 7:15 PM on November 14, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/309f796b39d4ae7694c3f37a681c1ebcd1f58eda for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
in src/qt/transactionview.cpp:None in 309f796b39
```
  82 | @@ -83,14 +83,12 @@
  83 |  
  84 |      addressWidget = new QLineEdit(this);
  85 |  #if QT_VERSION >= 0x040700
  86 | -    /* Do not move this to the XML file, Qt before 4.7 will choke on it */
```
laanwj commented at 6:53 AM on November 15, 2013:

Why removing this informative comment?

Diapolo commented at 8:03 AM on November 15, 2013:

Another file you recently created didn't have one either and I think the version ifdef makes clear it makes sense to have that code here ;)?

laanwj commented at 8:31 AM on November 15, 2013:

Right I don't really mind, I was just wondering.
laanwj commented at 8:56 AM on November 15, 2013: member

Still need to test this but code changes ACK
laanwj referenced this in commit 0b4bd485ba on Nov 16, 2013
laanwj merged this on Nov 16, 2013
laanwj closed this on Nov 16, 2013
Diapolo deleted the branch on Nov 16, 2013
Bushstar referenced this in commit 31afa9c0fc on Apr 8, 2020
Bushstar referenced this in commit a8e7133c65 on Apr 8, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Diapolo

BitcoinPullTester

laanwj