refactor: Remove workaround for resolved MSVC bug #32552

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:250518-fixed-msvc changing 1 files +7 −17
  1. hebasto commented at 4:33 pm on May 18, 2025: member
    The MSVC bug was fixed in Visual Studio version 17.11, and the Bitcoin Core project now requires Visual Studio version 17.13 or later.
  2. refactor: Remove workaround for resolved MSVC bug
    The MSVC bug was fixed in Visual Studio version 17.11, and the Bitcoin
    Core project now requires Visual Studio version 17.13 or later.
    f7df7f5023
  3. hebasto added the label Refactoring on May 18, 2025
  4. DrahtBot commented at 4:33 pm on May 18, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32552.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

  5. hebasto commented at 4:34 pm on May 18, 2025: member
  6. hebasto marked this as a draft on May 18, 2025
  7. hebasto closed this on May 18, 2025

  8. hebasto commented at 5:56 pm on May 18, 2025: member

    The MSVC bug was fixed in Visual Studio version 17.11, and the Bitcoin Core project now requires Visual Studio version 17.13 or later.

    It’s still broken in 17.14.0. Going to submit another bug report.

  9. l0rinc commented at 6:46 pm on May 18, 2025: contributor
    I have also tried the same in: #31991 (comment)
  10. hebasto commented at 8:13 pm on May 18, 2025: member

    The MSVC bug was fixed in Visual Studio version 17.11, and the Bitcoin Core project now requires Visual Studio version 17.13 or later.

    It’s still broken in 17.14.0. Going to submit another bug report.

    https://developercommunity.visualstudio.com/t/Bogus-C7595-error-on-valid-C20-code/10906093

  11. maflcko commented at 6:21 am on May 19, 2025: member
    It would be good to adjust the URL to avoid confusion and duplicate work and pull requests
  12. hebasto commented at 7:17 am on May 19, 2025: member

    It would be good to adjust the URL to avoid confusion and duplicate work and pull requests

    Sure. I’ll wait until it’s been properly triaged.

  13. maflcko commented at 10:32 am on May 19, 2025: member

    It would be good to adjust the URL to avoid confusion and duplicate work and pull requests

    Sure. I’ll wait until it’s been properly triaged.

    See https://github.com/bitcoin/bitcoin/pull/32561

  14. maflcko commented at 10:33 am on May 19, 2025: member
    If contributors here have a microsoft account, they may want to upvote the issue report, so that microsoft is aware that there is some interest in having it fixed.
  15. hebasto referenced this in commit ff1ee102c4 on May 19, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-05-25 18:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me