rpc, doc: clarify wallet version in getwalletinfo help #32603

1. 
   rkrux commented at 3:19 pm on May 23, 2025: contributor

   I noted in review of a previous PR here: #32553#pullrequestreview-2853743852.

   Relaying the same information in the RPC help that’s present in a code comment: https://github.com/bitcoin/bitcoin/blob/af65fd1a333011137dafd3df9a51704fd319feb4/src/wallet/wallet.h#L809-L810

2. 
   DrahtBot commented at 3:19 pm on May 23, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32603.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   Stale ACK	jonatack

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. in src/wallet/rpc/wallet.cpp:43 in 21ddfbf888 outdated

   39@@ -40,7 +40,7 @@ static RPCHelpMan getwalletinfo()
   40                     {
   41                         {
   42                         {RPCResult::Type::STR, "walletname", "the wallet name"},
   43-                        {RPCResult::Type::NUM, "walletversion", "the wallet version"},
   44+                        {RPCResult::Type::NUM, "walletversion", "the wallet version (the oldest client version guaranteed to understand this wallet)"},
   

   ---

   ---

   

   jonatack commented at 5:45 pm on May 23, 2025:

   “the wallet version” is redundant to the field name, whereas “current wallet format” provides a bit more context

   0                        {RPCResult::Type::NUM, "walletversion", "the current wallet format (the oldest client version guaranteed to understand this wallet)"},
   

   ---

   

   rkrux commented at 7:42 am on May 24, 2025:

   Makes sense, done.
4. 
   jonatack commented at 5:47 pm on May 23, 2025: member

   ACK 21ddfbf888dabed1bb89b30481f1391727f6212

   modulo nit suggestion, and PR/commit title s/wallet, rpc/rpc, doc/

   (suggest not linking to https://github.com/bitcoin/bitcoin/pull/32553#pullrequestreview-2853743852 in the commit message, as every push here adds a GitHub notification in that pull)

5. rpc, doc: clarify wallet version in getwalletinfo help

   I noted in review of a previous PR 32553.
   
   Relaying the same information in the RPC help that's present
   in a code comment: https://github.com/bitcoin/bitcoin/blob/af65fd1a333011137dafd3df9a51704fd319feb4/src/wallet/wallet.h#L809-L810

   058537331c
6. rkrux force-pushed on May 24, 2025
7. rkrux renamed this:
   wallet, rpc: clarify wallet version in getwalletinfo help
   rpc, doc: clarify wallet version in getwalletinfo help
   on May 24, 2025

Contributors
rkrux DrahtBot jonatack maflcko