test: fix sync function in rpc_psbt.py #32630

pull mzumsande wants to merge 1 commits into bitcoin:master from mzumsande:202505_fix_rpc_psbt changing 1 files +1 −1
  1. mzumsande commented at 3:25 pm on May 28, 2025: contributor

    Even though the block is created on node2, the sync is only between node1 and node0. Accordingly the test fails if I put a sleep in msg_type == NetMsgType::HEADERS processing: In this case, node1 and node0 do not hear about the new block, the sync still passes because they are in sync with each other, and later on in the test_input_confs_control subtest, node1 would generate a forked block instead of building on the previous one, leading to test failure.

    Haven’t seen this in the CI, but I ran into it on an experimental branch.

  2. test: fix sync function in rpc_psbt.py
    It currently only syncs between the first two nodes,
    which may do nothing when the block is created on the
    third node.
    4df4df45d7
  3. DrahtBot commented at 3:25 pm on May 28, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32630.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK maflcko, achow101

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Tests on May 28, 2025
  5. maflcko commented at 3:34 pm on May 28, 2025: member
    lgtm ACK 4df4df45d7bc2e8be99325d40cda936aab87c083
  6. achow101 commented at 7:35 pm on May 28, 2025: member
    ACK 4df4df45d7bc2e8be99325d40cda936aab87c083
  7. achow101 merged this on May 28, 2025
  8. achow101 closed this on May 28, 2025

  9. mzumsande deleted the branch on May 28, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-06-15 09:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me