wallet: sqlite: there is no need to have exclusive locking when mocking #32632

1. 
   brunoerg commented at 7:01 pm on May 28, 2025: contributor

   For in-memory SQLite databases, exclusive locking is generally not necessary because in-memory dbs are private to the connection that created them.
2. wallet: sqlite: there is no need to have exclusive locking when mocking

   For in-memory SQLite databases, exclusive locking is generally not
   necessary because in-memory dbs are private to the connection that
   created them.

   1b7920a20c
3. 
   DrahtBot commented at 7:01 pm on May 28, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32632.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

4. DrahtBot added the label Wallet on May 28, 2025
5. 
   achow101 commented at 7:46 pm on May 28, 2025: member

   Does this materially change anything for performance? If not, I’d rather keep it as is for simplicity.
6. 
   brunoerg commented at 7:03 pm on June 4, 2025: contributor

   Does this materially change anything for performance? If not, I’d rather keep it as is for simplicity.

   Yes, but it’s hard to measure, especially because mocking is used for testing. Anyway, we can keep as is.

7. brunoerg closed this on Jun 4, 2025

   ---

Contributors
brunoerg DrahtBot achow101

Labels
Wallet