[Qt] ensure payment request network matches client network #3265

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:paymentrequest_checknet changing 1 files +11 −1

Diapolo commented at 12:58 AM on November 16, 2013: none
- prevents the client to handle payment requests that do not match the clients network and shows a warning instead (was mainly a problem with drag&drop payment requests onto the client window)

[Qt] ensure payment request network matches client network

- prevents the client to handle payment requests that do not match the
  clients network and shows a warning instead (was mainly a problem with
  drag&drop payment requests onto the client window)

07dcfd03ae

BitcoinPullTester commented at 1:16 AM on November 16, 2013: none
Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/07dcfd03aedb0acf137950d5d82cc3c1959867f6 for binaries and test log.

This could happen for one of several reasons:
1. It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts (please tweak those patches in qa/pull-tester)
2. It adds/modifies tests which test network rules (thanks for doing that), which conflicts with a patch applied at test time
3. It does not build on either Linux i386 or Win32 (via MinGW cross compile)
4. The test suite fails on either Linux i386 or Win32
5. The block test-cases failed (lookup the first bNN identifier which failed in https://github.com/TheBlueMatt/test-scripts/blob/master/FullBlockTestGenerator.java)
If you believe this to be in error, please ping BlueMatt on freenode or TheBlueMatt here.

This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
Diapolo commented at 1:38 AM on November 16, 2013: none

<pre> tail: write error: Broken pipe tail: write error </pre>

Once more an unrelated error.

in src/qt/sendcoinsdialog.cpp:None in 07dcfd03ae

 323 | @@ -323,8 +324,17 @@ bool SendCoinsDialog::handlePaymentRequest(const SendCoinsRecipient &rv)
 324 |  {
 325 |      QString strSendCoins = tr("Send Coins");
 326 |      if (rv.paymentRequest.IsInitialized()) {
 327 | -        // Expired payment request?
 328 |          const payments::PaymentDetails& details = rv.paymentRequest.getDetails();
 329 | +

laanwj commented at 7:28 AM on November 16, 2013:

I think this check belongs in PaymentServer instead of SendCoinsDialog?

in src/qt/sendcoinsdialog.cpp:None in 07dcfd03ae

 329 | +
 330 | +        // Payment request network matches client network?
 331 | +        if ((details.network() == "main" && TestNet()) ||
 332 | +            (details.network() == "test" && !TestNet()))
 333 | +        {
 334 | +            emit message(strSendCoins, tr("Payment request network doesn't match clients network."),

laanwj commented at 7:28 AM on November 16, 2013:

I'd say "client network" not "clients network"

Diapolo commented at 3:02 PM on November 20, 2013: none

@laanwj Agreed, will rework this.
Diapolo commented at 1:00 PM on November 22, 2013: none

Closing until re-worked :).
Diapolo closed this on Nov 22, 2013
Bushstar referenced this in commit 42e104932d on Apr 8, 2020
Bushstar referenced this in commit 4439ce985a on Apr 8, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Diapolo

BitcoinPullTester

laanwj