docs: adds correct updated documentation links #32699

pull Zeegaths wants to merge 1 commits into bitcoin:master from Zeegaths:ship-docs-32565 changing 2 files +16 −11
  1. Zeegaths commented at 10:05 am on June 7, 2025: none
    Added correct links to the docs in place of the missing docs’ paths. Fixes #32565
  2. DrahtBot commented at 10:05 am on June 7, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32699.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #31974 (Drop testnet3 by Sjors)
    • #30277 ([DO NOT MERGE] Erlay: bandwidth-efficient transaction relay protocol (Full implementation) by sr-gi)
    • #17580 (refactor: Add ALLOW_LIST flags and enforce usage in CheckArgFlags by ryanofsky)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  3. DrahtBot added the label Docs on Jun 7, 2025
  4. mabu44 commented at 8:44 am on June 9, 2025: none
    This makes it necessary to manually update the links with every release, or at least with every new version that contains changes to those documentation files.
  5. Zeegaths commented at 4:13 pm on June 9, 2025: none

    This makes it necessary to manually update the links with every release, or at least with every new version that contains changes to those documentation files.

    it does, still trying to get a workaround that automatically updates it

  6. DrahtBot added the label Needs rebase on Jun 10, 2025
  7. Zeegaths commented at 11:43 am on June 11, 2025: none

    This makes it necessary to manually update the links with every release, or at least with every new version that contains changes to those documentation files.

    i have update it so it fetches the docs based on build version

  8. in src/wallet/init.cpp:70 in df115d0fb0 outdated 
    66@@ -66,7 +67,7 @@ void WalletInit::AddWalletOptions(ArgsManager& argsman) const
67     argsman.AddArg("-paytxfee=<amt>", strprintf("(DEPRECATED) Fee rate (in %s/kvB) to add to transactions you send (default: %s)",
68                                                             CURRENCY_UNIT, FormatMoney(CFeeRate{DEFAULT_PAY_TX_FEE}.GetFeePerK())), ArgsManager::ALLOW_ANY, OptionsCategory::WALLET);
69 #ifdef ENABLE_EXTERNAL_SIGNER
70-    argsman.AddArg("-signer=<cmd>", "External signing tool, see doc/external-signer.md", ArgsManager::ALLOW_ANY, OptionsCategory::WALLET);
71+    argsman.AddArg("-signer=<cmd>", strprintf("External signing tool, see https://github.com/bitcoin/bitcoin/blob/v%d.%d/doc/external-signer.md", CLIENT_VERSION_MAJOR, CLIENT_VERSION_MINOR), ArgsManager::ALLOW_ANY, OptionsCategory::WALLET);
    brunoerg commented at 4:36 pm on June 11, 2025:

    Running on master branch, I get:

    0 -signer=<cmd>
1       External signing tool, see
2       https://github.com/bitcoin/bitcoin/blob/v29.99/doc/external-signer.md

    …which is incorrect since there is no v29.99.

    Zeegaths commented at 7:05 pm on June 11, 2025:
    this could be because you are on developement version. Let me try set it to the latest stable version
  9. brunoerg commented at 4:40 pm on June 11, 2025: contributor
    You can squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits.
  10. Zeegaths commented at 7:05 pm on June 11, 2025: none

    You can squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits.

    thankyou for this

  11. Zeegaths force-pushed on Jun 12, 2025
  12. DrahtBot removed the label Needs rebase on Jun 12, 2025
  13. musaHaruna commented at 12:09 pm on June 16, 2025: none
    I checked out v29.0 with the changes, I got: -cjdnsreachable If set, then this host is configured for CJDNS (connecting to fc00::/8 addresses would lead us to the CJDNS network, see https://github.com/bitcoin/bitcoin/blob/v29.0/doc/cjdns.md) (default: 0) which links correctly, the function GetDocumentationUrl looks good to me
  14. Zeegaths commented at 12:26 pm on June 16, 2025: none

    Thankyou for the feedback

    On Mon, 16 Jun 2025 at 15:09, musaHaruna @.***> wrote:

    @.**** commented on this pull request.

    I checked out v29.0 with the changes, I got: -cjdnsreachable If set, then this host is configured for CJDNS (connecting to fc00::/8 addresses would lead us to the CJDNS network, see https://github.com/bitcoin/bitcoin/blob/v29.0/doc/cjdns.md) (default: 0) which links correctly, the function GetDocumentationUrl looks good to me

    — Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/32699#pullrequestreview-2931880588, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZVGWLGZSNRGKGVIZRYRJGL3D2XYVAVCNFSM6AAAAAB6ZXKXIOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSMZRHA4DANJYHA . You are receiving this because you authored the thread.Message ID: @.***>

  15. in src/init.cpp:160 in 40c23239a8 outdated 
    156@@ -157,7 +157,7 @@ static constexpr bool DEFAULT_STOPAFTERBLOCKIMPORT{false};
157 #endif
158 
159 static constexpr int MIN_CORE_FDS = MIN_LEVELDB_FDS + NUM_FDS_MESSAGE_CAPTURE;
160-static const char* DEFAULT_ASMAP_FILENAME="ip_asn.map";
161+static const char* DEFAULT_ASMAP_FILENAME = "ip_asn.map";
    b-l-u-e commented at 3:11 pm on June 16, 2025:

    Thanks for the PR! I notice there are some whitespace changes that appear unrelated to the main goal of fixing documentation references. While these changes don’t affect functionality, it would be helpful to keep the diff focused on the actual documentation URL changes. This makes the PR easier to review and reduces the risk of merge conflicts.

    Could you please remove these unrelated whitespace changes? This will make the PR’s intent clearer and follow the principle of keeping changes minimal and focused.

    The core changes to fix the documentation references look good.

  16. Zeegaths commented at 4:20 pm on June 16, 2025: none

    Thank you, I will do just that

    On Mon, 16 Jun 2025 at 18:12, Winnie Gitau @.***> wrote:

    @.**** commented on this pull request.

    In src/init.cpp https://github.com/bitcoin/bitcoin/pull/32699#discussion_r2150261914:

    @@ -157,7 +157,7 @@ static constexpr bool DEFAULT_STOPAFTERBLOCKIMPORT{false}; #endif

    static constexpr int MIN_CORE_FDS = MIN_LEVELDB_FDS + NUM_FDS_MESSAGE_CAPTURE; -static const char* DEFAULT_ASMAP_FILENAME=“ip_asn.map”; +static const char* DEFAULT_ASMAP_FILENAME = “ip_asn.map”;

    Thanks for the PR! I notice there are some whitespace changes that appear unrelated to the main goal of fixing documentation references. While these changes don’t affect functionality, it would be helpful to keep the diff focused on the actual documentation URL changes. This makes the PR easier to review and reduces the risk of merge conflicts.

    Could you please remove these unrelated whitespace changes? This will make the PR’s intent clearer and follow the principle of keeping changes minimal and focused.

    The core changes to fix the documentation references look good.

    — Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/32699#pullrequestreview-2932549034, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZVGWLD5HTPO47YKQ2QXSG33D3NEPAVCNFSM6AAAAAB6ZXKXIOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSMZSGU2DSMBTGQ . You are receiving this because you authored the thread.Message ID: @.***>

  17. Zeegaths force-pushed on Jun 18, 2025
  18. in src/init.cpp:444 in bd413c1b0d outdated 
    437@@ -437,7 +438,18 @@ static void registerSignalHandler(int signal, void(*handler)(int))
438     sigaction(signal, &sa, nullptr);
439 }
440 #endif
441-
442+std::string GetDocumentationUrl(const std::string& doc_path)
443+{
444+    if (CLIENT_VERSION_MINOR == 99) {
445+        std::string stable_version = strprintf("v%d.0", CLIENT_VERSION_MAJOR);
    luke-jr commented at 7:41 pm on June 24, 2025: 
    0        std::string stable_version = strprintf("v%d.0", CLIENT_VERSION_MAJOR + 1);
    Zeegaths commented at 7:10 pm on June 25, 2025:
    when i run this, it goes to version 30, which does not exist yet..,
  19. maflcko commented at 12:40 pm on July 18, 2025: member
    Can this be drafted/closed, or are you still working on this?
  20. Zeegaths commented at 5:34 pm on July 18, 2025: none

    Yes, it’s done.

    On Fri, 18 Jul 2025 at 15:41, maflcko @.***> wrote:

    maflcko left a comment (bitcoin/bitcoin#32699) https://github.com/bitcoin/bitcoin/pull/32699#issuecomment-3089360188

    Can this be drafted/closed, or are you still working on this?

    — Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/32699#issuecomment-3089360188, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZVGWLBQ4RMG7UWJVYM6WG33JDTOFAVCNFSM6AAAAAB6ZXKXIOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAOBZGM3DAMJYHA . You are receiving this because you authored the thread.Message ID: @.***>

  21. maflcko commented at 2:18 pm on July 21, 2025: member
    No, you haven’t replied/addressed the feedback from June: #32699 (review)
  22. Zeegaths commented at 5:19 pm on July 21, 2025: none

    thanks for pointing that out. all good now

    On Mon, 21 Jul 2025 at 17:19, maflcko @.***> wrote:

    maflcko left a comment (bitcoin/bitcoin#32699) https://github.com/bitcoin/bitcoin/pull/32699#issuecomment-3096984862

    No, you haven’t replied/addressed the feedback from June: #32699 (comment) https://github.com/bitcoin/bitcoin/pull/32699#discussion_r2150261914

    — Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/32699#issuecomment-3096984862, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZVGWLHFAQADBZYLO2USSGD3JTZFVAVCNFSM6AAAAAB6ZXKXIOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAOJWHE4DIOBWGI . You are receiving this because you authored the thread.Message ID: @.***>

  23. maflcko commented at 9:37 am on July 22, 2025: member

    all good now

    no, it is not. This can be seen if you take a look at the changes yourself.

    Also, it would have to be squashed, as already explained above as well.

    Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits

  24. Zeegaths force-pushed on Jul 22, 2025
  25. Zeegaths force-pushed on Jul 22, 2025
  26. DrahtBot added the label CI failed on Jul 22, 2025
  27. DrahtBot commented at 7:09 pm on July 22, 2025: contributor

    🚧 At least one of the CI tasks failed. Task ARM, unit tests, no functional tests: https://github.com/bitcoin/bitcoin/runs/46503198633 LLM reason (✨ experimental): The failure is caused by a syntax error and an undefined function in init.cpp.

    Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

    • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

    • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

    • An intermittent issue.

    Leave a comment here, if you need help tracking down a confusing failure.

  28. Zeegaths closed this on Jul 22, 2025
  29. Zeegaths force-pushed on Jul 22, 2025
  30. Zeegaths deleted the branch on Jul 22, 2025
  31. Zeegaths restored the branch on Jul 22, 2025
  32. Zeegaths reopened this on Jul 22, 2025
  33. in src/init.cpp:446 in 5ff503938e outdated 
    437@@ -438,6 +438,18 @@ static void registerSignalHandler(int signal, void(*handler)(int))
438 }
439 #endif
440 
441+std::string GetDocumentationUrl(const std::string& doc_path)
442+{
443+    if (CLIENT_VERSION_MINOR == 99) {
444+        std::string stable_version = strprintf("v%d.0", CLIENT_VERSION_MAJOR);
445+        return strprintf("https://github.com/bitcoin/bitcoin/blob/%s/doc/%s", stable_version, doc_path);
446+        ;
    b-l-u-e commented at 8:44 pm on July 22, 2025:
    There’s an unnecessary semicolon on its own line that should be removed.
  34. DrahtBot removed the label CI failed on Jul 22, 2025
  35. Zeegaths commented at 9:33 am on July 23, 2025: none

    Fixed!

    On Tue, 22 Jul 2025 at 23:44, Winnie Gitau @.***> wrote:

    @.**** commented on this pull request.

    In src/init.cpp https://github.com/bitcoin/bitcoin/pull/32699#discussion_r2223787842:

    @@ -438,6 +438,18 @@ static void registerSignalHandler(int signal, void(*handler)(int)) } #endif

    +std::string GetDocumentationUrl(const std::string& doc_path) +{

    • if (CLIENT_VERSION_MINOR == 99) {
    •    std::string stable_version = strprintf("v%d.0", CLIENT_VERSION_MAJOR);

    •    return strprintf("https://github.com/bitcoin/bitcoin/blob/%s/doc/%s", stable_version, doc_path);

    •    ;

    There’s an unnecessary semicolon on its own line that should be removed.

    — Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/32699#pullrequestreview-3044818666, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZVGWLA4EKFVAEIR6Z77EPT3J2PCVAVCNFSM6AAAAAB6ZXKXIOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTANBUHAYTQNRWGY . You are receiving this because you modified the open/close state.Message ID: @.***>

  36. adds correct documentation links 
    adds correct documentation links
    44ac87befc
  37. Zeegaths force-pushed on Jul 23, 2025


Zeegaths DrahtBot mabu44 brunoerg musaHaruna b-l-u-e luke-jr maflcko

Labels
Docs

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-07-31 03:13 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me