docs: adds correct updated documentation links #32699
pull Zeegaths wants to merge 1 commits into bitcoin:master from Zeegaths:ship-docs-32565 changing 2 files +96 −78-
Zeegaths commented at 10:05 am on June 7, 2025: noneAdded correct links to the docs in place of the missing docs’ paths. Fixes #32565
-
DrahtBot commented at 10:05 am on June 7, 2025: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32699.
Reviews
See the guideline for information on the review process. A summary of reviews will appear here.
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #32541 (index: store per-block transaction locations for efficient lookups by romanz)
- #31974 (Drop testnet3 by Sjors)
- #31860 (init: Take lock on blocks directory in BlockManager ctor by TheCharlatan)
- #31845 (Add -pruneduringinit option to temporarily use another prune target during IBD by luke-jr)
- #29678 (Bugfix: Correct first-run free space checks by luke-jr)
- #29278 (Wallet: Add
maxfeerate
wallet startup option by ismaelsadeeq) - #28792 (Embed default ASMap as binary dump header file by fjahr)
- #26966 (index: initial sync speedup, parallelize process by furszy)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
LLM Linter (✨ experimental)
Possible typos and grammar issues:
- In the
-peerbloomfilters
help text: “Support filtering of blocks and transaction with bloom filters” → “transactions” [plural “transactions” is needed] No other typos impacting comprehension were found.
drahtbot_id_4_m
-
DrahtBot added the label Docs on Jun 7, 2025
-
mabu44 commented at 8:44 am on June 9, 2025: noneThis makes it necessary to manually update the links with every release, or at least with every new version that contains changes to those documentation files.
-
Zeegaths commented at 4:13 pm on June 9, 2025: none
This makes it necessary to manually update the links with every release, or at least with every new version that contains changes to those documentation files.
it does, still trying to get a workaround that automatically updates it
-
DrahtBot added the label Needs rebase on Jun 10, 2025
-
Zeegaths commented at 11:43 am on June 11, 2025: none
This makes it necessary to manually update the links with every release, or at least with every new version that contains changes to those documentation files.
i have update it so it fetches the docs based on build version
-
in src/wallet/init.cpp:70 in df115d0fb0 outdated
66@@ -66,7 +67,7 @@ void WalletInit::AddWalletOptions(ArgsManager& argsman) const 67 argsman.AddArg("-paytxfee=<amt>", strprintf("(DEPRECATED) Fee rate (in %s/kvB) to add to transactions you send (default: %s)", 68 CURRENCY_UNIT, FormatMoney(CFeeRate{DEFAULT_PAY_TX_FEE}.GetFeePerK())), ArgsManager::ALLOW_ANY, OptionsCategory::WALLET); 69 #ifdef ENABLE_EXTERNAL_SIGNER 70- argsman.AddArg("-signer=<cmd>", "External signing tool, see doc/external-signer.md", ArgsManager::ALLOW_ANY, OptionsCategory::WALLET); 71+ argsman.AddArg("-signer=<cmd>", strprintf("External signing tool, see https://github.com/bitcoin/bitcoin/blob/v%d.%d/doc/external-signer.md", CLIENT_VERSION_MAJOR, CLIENT_VERSION_MINOR), ArgsManager::ALLOW_ANY, OptionsCategory::WALLET);
brunoerg commented at 4:36 pm on June 11, 2025:Running on master branch, I get:
0 -signer=<cmd> 1 External signing tool, see 2 https://github.com/bitcoin/bitcoin/blob/v29.99/doc/external-signer.md
…which is incorrect since there is no v29.99.
Zeegaths commented at 7:05 pm on June 11, 2025:this could be because you are on developement version. Let me try set it to the latest stable versionbrunoerg commented at 4:40 pm on June 11, 2025: contributorYou can squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits.Zeegaths commented at 7:05 pm on June 11, 2025: noneYou can squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits.
thankyou for this
outputs latest stable version for development 40c23239a8Zeegaths force-pushed on Jun 12, 2025DrahtBot removed the label Needs rebase on Jun 12, 2025
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-06-15 06:13 UTC
More mirrored repositories can be found on mirror.b10c.me