docs: adds correct updated documentation links #32699

pull Zeegaths wants to merge 2 commits into bitcoin:master from Zeegaths:ship-docs-32565 changing 2 files +93 −84
  1. Zeegaths commented at 10:05 am on June 7, 2025: none
    Added correct links to the docs in place of the missing docs’ paths. Fixes #32565
  2. DrahtBot commented at 10:05 am on June 7, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32699.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #32541 (index: store per-block transaction locations for efficient lookups by romanz)
    • #31974 (Drop testnet3 by Sjors)
    • #31860 (init: Take lock on blocks directory in BlockManager ctor by TheCharlatan)
    • #31845 (Add -pruneduringinit option to temporarily use another prune target during IBD by luke-jr)
    • #29678 (Bugfix: Correct first-run free space checks by luke-jr)
    • #29415 (Broadcast own transactions only via short-lived Tor or I2P connections by vasild)
    • #29278 (Wallet: Add maxfeerate wallet startup option by ismaelsadeeq)
    • #28792 (Embed default ASMap as binary dump header file by fjahr)
    • #26966 (index: initial sync speedup, parallelize process by furszy)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

    LLM Linter (✨ experimental)

    Possible typos and grammar issues:

    • ““thus -> " thus [remove extraneous quote before thus in the string literal]

    drahtbot_id_4_m

  3. DrahtBot added the label Docs on Jun 7, 2025
  4. mabu44 commented at 8:44 am on June 9, 2025: none
    This makes it necessary to manually update the links with every release, or at least with every new version that contains changes to those documentation files.
  5. Zeegaths commented at 4:13 pm on June 9, 2025: none

    This makes it necessary to manually update the links with every release, or at least with every new version that contains changes to those documentation files.

    it does, still trying to get a workaround that automatically updates it

  6. DrahtBot added the label Needs rebase on Jun 10, 2025
  7. Zeegaths commented at 11:43 am on June 11, 2025: none

    This makes it necessary to manually update the links with every release, or at least with every new version that contains changes to those documentation files.

    i have update it so it fetches the docs based on build version

  8. in src/wallet/init.cpp:70 in df115d0fb0 outdated 
    66@@ -66,7 +67,7 @@ void WalletInit::AddWalletOptions(ArgsManager& argsman) const
67     argsman.AddArg("-paytxfee=<amt>", strprintf("(DEPRECATED) Fee rate (in %s/kvB) to add to transactions you send (default: %s)",
68                                                             CURRENCY_UNIT, FormatMoney(CFeeRate{DEFAULT_PAY_TX_FEE}.GetFeePerK())), ArgsManager::ALLOW_ANY, OptionsCategory::WALLET);
69 #ifdef ENABLE_EXTERNAL_SIGNER
70-    argsman.AddArg("-signer=<cmd>", "External signing tool, see doc/external-signer.md", ArgsManager::ALLOW_ANY, OptionsCategory::WALLET);
71+    argsman.AddArg("-signer=<cmd>", strprintf("External signing tool, see https://github.com/bitcoin/bitcoin/blob/v%d.%d/doc/external-signer.md", CLIENT_VERSION_MAJOR, CLIENT_VERSION_MINOR), ArgsManager::ALLOW_ANY, OptionsCategory::WALLET);
    brunoerg commented at 4:36 pm on June 11, 2025:

    Running on master branch, I get:

    0 -signer=<cmd>
1       External signing tool, see
2       https://github.com/bitcoin/bitcoin/blob/v29.99/doc/external-signer.md

    …which is incorrect since there is no v29.99.

    Zeegaths commented at 7:05 pm on June 11, 2025:
    this could be because you are on developement version. Let me try set it to the latest stable version
  9. brunoerg commented at 4:40 pm on June 11, 2025: contributor
    You can squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits.
  10. Zeegaths commented at 7:05 pm on June 11, 2025: none

    You can squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits.

    thankyou for this

  11. Zeegaths force-pushed on Jun 12, 2025
  12. DrahtBot removed the label Needs rebase on Jun 12, 2025
  13. musaHaruna commented at 12:09 pm on June 16, 2025: none
    I checked out v29.0 with the changes, I got: -cjdnsreachable If set, then this host is configured for CJDNS (connecting to fc00::/8 addresses would lead us to the CJDNS network, see https://github.com/bitcoin/bitcoin/blob/v29.0/doc/cjdns.md) (default: 0) which links correctly, the function GetDocumentationUrl looks good to me
  14. Zeegaths commented at 12:26 pm on June 16, 2025: none

    Thankyou for the feedback

    On Mon, 16 Jun 2025 at 15:09, musaHaruna @.***> wrote:

    @.**** commented on this pull request.

    I checked out v29.0 with the changes, I got: -cjdnsreachable If set, then this host is configured for CJDNS (connecting to fc00::/8 addresses would lead us to the CJDNS network, see https://github.com/bitcoin/bitcoin/blob/v29.0/doc/cjdns.md) (default: 0) which links correctly, the function GetDocumentationUrl looks good to me

    — Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/32699#pullrequestreview-2931880588, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZVGWLGZSNRGKGVIZRYRJGL3D2XYVAVCNFSM6AAAAAB6ZXKXIOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSMZRHA4DANJYHA . You are receiving this because you authored the thread.Message ID: @.***>

  15. in src/init.cpp:160 in 40c23239a8 outdated 
    156@@ -157,7 +157,7 @@ static constexpr bool DEFAULT_STOPAFTERBLOCKIMPORT{false};
157 #endif
158 
159 static constexpr int MIN_CORE_FDS = MIN_LEVELDB_FDS + NUM_FDS_MESSAGE_CAPTURE;
160-static const char* DEFAULT_ASMAP_FILENAME="ip_asn.map";
161+static const char* DEFAULT_ASMAP_FILENAME = "ip_asn.map";
    b-l-u-e commented at 3:11 pm on June 16, 2025:

    Thanks for the PR! I notice there are some whitespace changes that appear unrelated to the main goal of fixing documentation references. While these changes don’t affect functionality, it would be helpful to keep the diff focused on the actual documentation URL changes. This makes the PR easier to review and reduces the risk of merge conflicts.

    Could you please remove these unrelated whitespace changes? This will make the PR’s intent clearer and follow the principle of keeping changes minimal and focused.

    The core changes to fix the documentation references look good.

  16. Zeegaths commented at 4:20 pm on June 16, 2025: none

    Thank you, I will do just that

    On Mon, 16 Jun 2025 at 18:12, Winnie Gitau @.***> wrote:

    @.**** commented on this pull request.

    In src/init.cpp https://github.com/bitcoin/bitcoin/pull/32699#discussion_r2150261914:

    @@ -157,7 +157,7 @@ static constexpr bool DEFAULT_STOPAFTERBLOCKIMPORT{false}; #endif

    static constexpr int MIN_CORE_FDS = MIN_LEVELDB_FDS + NUM_FDS_MESSAGE_CAPTURE; -static const char* DEFAULT_ASMAP_FILENAME=“ip_asn.map”; +static const char* DEFAULT_ASMAP_FILENAME = “ip_asn.map”;

    Thanks for the PR! I notice there are some whitespace changes that appear unrelated to the main goal of fixing documentation references. While these changes don’t affect functionality, it would be helpful to keep the diff focused on the actual documentation URL changes. This makes the PR easier to review and reduces the risk of merge conflicts.

    Could you please remove these unrelated whitespace changes? This will make the PR’s intent clearer and follow the principle of keeping changes minimal and focused.

    The core changes to fix the documentation references look good.

    — Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/32699#pullrequestreview-2932549034, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZVGWLD5HTPO47YKQ2QXSG33D3NEPAVCNFSM6AAAAAB6ZXKXIOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSMZSGU2DSMBTGQ . You are receiving this because you authored the thread.Message ID: @.***>

  17. outputs latest stable version for development 
    removes whitespace
    d3f0b45a06
  18. Zeegaths force-pushed on Jun 18, 2025
  19. Merge branch 'bitcoin:master' into ship-docs-32565 bd413c1b0d
  20. in src/init.cpp:444 in bd413c1b0d 
    437@@ -437,7 +438,18 @@ static void registerSignalHandler(int signal, void(*handler)(int))
438     sigaction(signal, &sa, nullptr);
439 }
440 #endif
441-
442+std::string GetDocumentationUrl(const std::string& doc_path)
443+{
444+    if (CLIENT_VERSION_MINOR == 99) {
445+        std::string stable_version = strprintf("v%d.0", CLIENT_VERSION_MAJOR);
    luke-jr commented at 7:41 pm on June 24, 2025: 
    0        std::string stable_version = strprintf("v%d.0", CLIENT_VERSION_MAJOR + 1);
    Zeegaths commented at 7:10 pm on June 25, 2025:
    when i run this, it goes to version 30, which does not exist yet..,


Zeegaths DrahtBot mabu44 brunoerg musaHaruna b-l-u-e luke-jr

Labels
Docs

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-07-08 12:13 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me