Make users accustomed to the other subdivision units (mBTC, muBTC) by showing the total amount in all units in the confirmation dialog.
This was recently raised on the mailing list and could be a preparation for switching over the default unit eventually.
Make users accustomed to the other subdivision units (mBTC, muBTC)
by showing the total amount in all units in the confirmation dialog.
This was recently raised on the mailing list and could be a preparation
for switching over the default unit eventually.
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/fb0507fe4b3ff733386c8e3580032cfc965eec17 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
230 | - questionString.append(tr("Total Amount %1").arg(BitcoinUnits::formatWithUnit(model->getOptionsModel()->getDisplayUnit(), currentTransaction.getTotalTransactionAmount()+txFee))); 231 | + if(u != model->getOptionsModel()->getDisplayUnit()) 232 | + alternativeUnits.append(BitcoinUnits::formatWithUnit(u, totalAmount)); 233 | } 234 | + questionString.append(tr("Total Amount %1 (= %2)") 235 | + .arg(BitcoinUnits::formatWithUnit(model->getOptionsModel()->getDisplayUnit(), totalAmount))
Nit: Can you use 4 space indentation for these?
Let's not argue about the amount of indentation...
216 | @@ -217,12 +217,19 @@ void SendCoinsDialog::on_sendButton_clicked() 217 | questionString.append("</span> "); 218 | questionString.append(tr("added as transaction fee")); 219 | } 220 | - if(txFee > 0 || recipients.count() > 1)
Why remove this check? AFAIK we just display a total, if there was a fee.
Because I want to always show the total in all units, even if there is no fee
Agreed
ACK to the idea, didn't test the code... but looks sane :).