net, rpc, qt: add per-peer blocktxn stats to getpeerinfo and qt debug window #32732

1. 
   waketraindev commented at 10:30 pm on June 11, 2025: none

   Adds per-peer tracking of the TX count and byte size of the last BLOCKTXN message sent. These stats are exposed via getpeerinfo and displayed in the Qt debug window.
2. 
   DrahtBot commented at 10:30 pm on June 11, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32732.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #27052 (test: rpc: add last block announcement time to getpeerinfo result by LarryRuane)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

3. waketraindev force-pushed on Jun 11, 2025
4. DrahtBot added the label CI failed on Jun 11, 2025
5. 
   DrahtBot commented at 10:40 pm on June 11, 2025: contributor

   🚧 At least one of the CI tasks failed. Task lint: https://github.com/bitcoin/bitcoin/runs/43929845422 LLM reason (✨ experimental): The failure is caused by a trailing whitespace error detected during the lint check.

   Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

   • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

   • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

   • An intermittent issue.

   Leave a comment here, if you need help tracking down a confusing failure.

6. net: added m_last_blocktxn_size and m_last_blocktxn_count to the Peer and CNodeStateStats 6ef037d996
7. waketraindev force-pushed on Jun 11, 2025
8. waketraindev force-pushed on Jun 11, 2025
9. rpc: added last_blocktxn_count and last_blocktxn_size to the output of getpeerinfo rpc 4fbcb17787
10. qt: extended the debug window ui to show last blocktxn size and count per peer cde36d8617
11. waketraindev force-pushed on Jun 12, 2025
12. waketraindev marked this as a draft on Jun 12, 2025
13. test: add last_blocktxn_count and size to functional test rpc_net.py 93f3c84ec0
14. waketraindev marked this as ready for review on Jun 12, 2025
15. DrahtBot removed the label CI failed on Jun 12, 2025
16. 
    maflcko commented at 6:16 am on June 12, 2025: member

    Not sure. Why should those debug-only stats be exposed on the rpc and the gui?
17. waketraindev closed this on Jun 12, 2025

    ---

18. waketraindev deleted the branch on Jun 12, 2025
19. 
    waketraindev commented at 9:39 am on June 12, 2025: none

    Thanks for the feedback, makes sense. I use this in my node monitoring tooling. Closed.

Contributors
waketraindev DrahtBot maflcko