wallet: add interface for storing generic data on destinations #3281

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2013_11_wallet_destdata changing 4 files +90 −0

laanwj commented at 12:52 PM on November 19, 2013: member
Add "destdata" record type to wallet, as well as accessor functions on CWallet and CWalletDB. This can be used by the UI to store arbitrary data tuples to be associated with a tx destination in the wallet.

A destdata tuple in the wallet is of the form (address, key, value) where the key acts to distinguish different types of generic data.

The purpose of this is to give the GUI a way to store:
- When an address table record was created (for #3207)
- The invoice Payment URI associated with a receiving address (for #3207)
- Outgoing payment requests (as soon as the GUI for this is ready), so that they can be associated with incoming transaction outputs when paid (transaction details could show this information...)
And possibly other data later.

I'll add tests when this is deemed a sane change.

wallet: add interface for storing generic data on destinations

Add "destdata" record type to wallet, as well as accessor functions
on CWallet and CWalletDB. This can be used by the UI to store
arbitrary data tuples to be associated with a
tx destination in the wallet.

A destdata tuple in the wallet is of the form (address, key, value)
where the key acts to distinguish different types of generic data.

The purpose of this is to give the GUI a way to store:

- When an address table record was created (for #3207)
- The invoice Payment URI associated with a receiving address (for #3207)
- Outgoing payment requests (as soon as the GUI for this is ready), so
  that they can be associated with transactions when paid (transaction
  details could show this information...)

And possibly other data later.

8e06e2f48c

in src/wallet.h:None in 35f21fdfa7 outdated

  79 | @@ -80,6 +80,9 @@ class CAddressBookData
  80 |      {
  81 |          purpose = "unknown";
  82 |      }
  83 | +
  84 | +    typedef std::map<std::string, std::string> StringMap;
  85 | +    StringMap gendata;

sipa commented at 12:33 PM on November 22, 2013:

What does "gen" stand for?

laanwj commented at 12:34 PM on November 22, 2013:

GENeric data, is a leftover, should be destdata

BitcoinPullTester commented at 4:08 PM on November 27, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/8e06e2f48ce284775e8620cd39378c6e43bcf156 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj commented at 11:01 AM on December 12, 2013: member

Closing this for now
laanwj closed this on Dec 12, 2013
sipa commented at 3:59 PM on January 13, 2014: member

I think this can be reopened - the only objection ever was some confusion about a variable name...
laanwj reopened this on Jan 13, 2014
laanwj commented at 4:02 PM on January 13, 2014: member

Yes, I closed it because I had too many other active pulls in the air at that point, not because of any problem with the code. Reopened. Edit: also needs rebase it appears
laanwj commented at 1:27 PM on January 15, 2014: member

Closing in favor of #3521
laanwj closed this on Jan 15, 2014
Bushstar referenced this in commit e732a9281c on Apr 8, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

laanwj

sipa

BitcoinPullTester

Linked (view graph)

#3207 qt: keep a list of requested payments