Followup to #32736 to restore the intended behaviour (absent the detailed logging which appears to not be practical with std::filesystem).
Bugfix: Wallet: Skip inaccessible directories rather than abort the wallet list entirely #32812
pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:fix_wallet_list_ignore_eperm changing 1 files +1 −1-
luke-jr commented at 3:05 PM on June 25, 2025: member
-
Bugfix: Wallet: Skip inaccessible directories rather than abort the wallet list entirely 2be6089394
-
DrahtBot commented at 3:05 PM on June 25, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32812.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process. A summary of reviews will appear here.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
- fanquake requested review from rkrux on Jun 25, 2025
- fanquake requested review from hodlinator on Jun 25, 2025
-
maflcko commented at 3:25 PM on June 25, 2025: member
pretty sure the tests are going to fail now? maybe the ci should go back to run in a user account, if possible?
-
luke-jr commented at 6:51 PM on June 25, 2025: member
This actually isn't necessary. Unreadable subdirectories get skipped explicitly when checking for their wallet.dat fails.
- luke-jr closed this on Jun 25, 2025
