contrib: correct variable name in p2p_monitor.py #32816
pull leopardracer wants to merge 1 commits into bitcoin:master from leopardracer:master changing 1 files +5 −5-
leopardracer commented at 10:07 am on June 26, 2025: contributorFix typo in variable name in p2p_monitor.py.
-
Update p2p_monitor.py 6bb38bf37f
-
DrahtBot commented at 10:07 am on June 26, 2025: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32816.
Reviews
See the guideline for information on the review process.
Type Reviewers ACK maflcko If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
-
leopardracer renamed this:
Update p2p_monitor.py
correct variable name in p2p_monitor.py
on Jun 26, 2025 -
DrahtBot renamed this:
correct variable name in p2p_monitor.py
correct variable name in p2p_monitor.py
on Jun 26, 2025 -
0xB10C commented at 1:38 pm on June 26, 2025: contributorThis just fixes a typo in AVALIABLE -> AVAILABLE. I don’t think this is good use of reviewer time. Functionally is not affected.
-
leopardracer commented at 2:10 pm on June 26, 2025: contributor
This just fixes a typo in AVALIABLE -> AVAILABLE. I don’t think this is good use of reviewer time. Functionally is not affected. @0xB10C totally get that this seems minor, but I think even small things like typos matter, especially in a repo like Bitcoin. It’s such a high-profile project that sets the tone for the whole ecosystem
-
0xB10C commented at 2:44 pm on June 26, 2025: contributor
Why doesn’t the description say it fixes a typo?
- Replaced hardcoded row calculations with the
ROWS_AVAILABLE_FOR_LIST
variable for improved readability and maintainability.
- Replaced hardcoded row calculations with the
-
leopardracer commented at 2:53 pm on June 26, 2025: contributor
Why doesn’t the description say it fixes a typo?
- Replaced hardcoded row calculations with the
ROWS_AVAILABLE_FOR_LIST
variable for improved readability and maintainability. @0xB10C description updated
- Replaced hardcoded row calculations with the
-
maflcko commented at 3:53 pm on June 26, 2025: memberlgtm ACK 6bb38bf37fd81a9ce2b66a3f078375dce9274754
-
leopardracer commented at 1:53 pm on June 27, 2025: contributor
lgtm ACK @maflcko everything is ok?
-
fanquake renamed this:
correct variable name in p2p_monitor.py
contrib: correct variable name in p2p_monitor.py
on Jun 30, 2025 -
DrahtBot added the label Scripts and tools on Jun 30, 2025
-
fanquake merged this on Jul 1, 2025
-
fanquake closed this on Jul 1, 2025
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-07-04 09:13 UTC
More mirrored repositories can be found on mirror.b10c.me