[Qt] coin-control features GUI cleanup 2 and 3 #3285

pull Diapolo wants to merge 2 commits into bitcoin:master from Diapolo:cc_cleanup2 changing 4 files +147 −101

Diapolo commented at 2:55 PM on November 20, 2013: none
- remove monospace labels from sendcoinsdialog also
- use a validated line edit for the change address
- add a tooltip to change address switch
- ensure we have a valid change address in CoinControlDialog::coinControl->destChange or just CNoDestination()
- some small ui file changes
- remove style sheets from ui files and use Qt attributes instead
- make some more strings untranslatable, to make life for translators easier
- split up long tooltips and rework the texts a little
Diapolo commented at 6:05 PM on November 21, 2013: none

I have more string and translations updates, but don't want to bloat this pull, so it get's merged faster. @laanwj Can you take a look please?
Diapolo commented at 1:21 PM on December 1, 2013: none

@laanwj Same here, I have more to come for coin control, but would love to see this merged first...
laanwj commented at 6:32 AM on December 2, 2013: member

@diapolo Code changes are OK, if you want to continue along these lines you could create a pull request that depends on this one (I did the same with #3332 and #3320)

[Qt] coin-control features GUI cleanup 2

- remove monospace labels from sendcoinsdialog also
- use a validated line edit for the change address
- add a tooltip to change address switch
- ensure we have a valid change address in
  CoinControlDialog::coinControl->destChange or just CNoDestination()
- some small ui file changes

834e14e57f

[Qt] coin-control features GUI cleanup 3

- remove style sheets from ui files and use Qt attributes instead
- make some more strings untranslatable, to make life for translators
  easier
- split up long tooltips an rework the texts a little

d3207b6fa8

Diapolo commented at 12:40 PM on December 2, 2013: none

@laanwj As it were mostly text and ui file changes I added a new commit to this pull instead.
BitcoinPullTester commented at 1:14 PM on December 2, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/d3207b6fa8283cdd15bfa89b222880cf20524c35 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj referenced this in commit f15bd3c96f on Dec 3, 2013
laanwj merged this on Dec 3, 2013
laanwj closed this on Dec 3, 2013
Diapolo deleted the branch on Dec 5, 2013
Bushstar referenced this in commit 1c885bbedf on Apr 8, 2020
Bushstar referenced this in commit 1be2f94d03 on Apr 8, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Diapolo

laanwj

BitcoinPullTester