test: break feature_block into subtests? #32877

issue brunoerg openend this issue on July 4, 2025
  1. brunoerg commented at 1:46 pm on July 4, 2025: contributor

    According to corecheck, feature_block is the slowest functional test and it’s taking about 70 seconds to run. feature_block is a huge functional test that tests many things - large re-orgs, block with invalid transactions, disabled opcodes, sigop counts, etc. These things are not necessarily coupled and could be broken into subtests and then we could run some of them instead of the whole test (see #30991) when necessary.

    The motivation for it is our mutation testing analysis. feature_block is important on the analysis of some files but not the whole test. That said, spending 70 seconds on a single test per mutant is making our analysis to take a long time.

  2. maflcko commented at 2:06 pm on July 4, 2025: member

    These things are not necessary coupled

    Are you sure? I’d say the reorg test is useful to perform on a “dirty” state.

    Other than that, I think the reorg test is the slowest part of the test, so if you want to run the test twice (once with reorg and once without reorg), it should be fine and also solve your issue?


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-07-07 21:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me