test: Turn rpcauth.py test into functional test #32881

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2507-test-rpcauth-fun changing 7 files +27 −31
  1. maflcko commented at 3:30 pm on July 5, 2025: member

    Currently the rpcauth-test.py is problematic, because:

    • The boilerplate for the test runner is duplicate or inconsistent with the other (functional) tests. Specifically ConfigParser.
    • The cmake/ci behavior is brittle and can silently fail, as explained in #31476.
    • Outside of ctest, this single test has to be run manually and separately, which is easy to forget.
    • If the test is manually called, it runs single threaded, when it could just run in parallel with the other functional tests.
    • It is also the only “unit” test written in Python, but not called by the functional test runner.

    Fix all issues by turning it into a functional test.

  2. DrahtBot commented at 3:31 pm on July 5, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32881.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #32865 (cmake: Use AUTHOR_WARNING for warnings by fanquake)
    • #32773 (cmake: Create subdirectories in build tree in advance by hebasto)
    • #29247 (CAT in Tapscript (BIP-347) by arminsabouri)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  3. maflcko renamed this:
    Turn rpcauth.py test into functional test
    test: Turn rpcauth.py test into functional test
    on Jul 5, 2025
  4. DrahtBot added the label Tests on Jul 5, 2025
  5. maflcko force-pushed on Jul 5, 2025
  6. DrahtBot added the label CI failed on Jul 5, 2025
  7. DrahtBot commented at 3:33 pm on July 5, 2025: contributor

    🚧 At least one of the CI tasks failed. Task lint: https://github.com/bitcoin/bitcoin/runs/45404790802 LLM reason (✨ experimental): The CI failure was caused by a lint check that detected a coding style violation (unused import and a spelling error), which caused the linting step to fail.

    Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

    • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

    • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

    • An intermittent issue.

    Leave a comment here, if you need help tracking down a confusing failure.

  8. Turn rpcauth.py test into functional test fa8a55e116
  9. maflcko force-pushed on Jul 5, 2025
  10. DrahtBot removed the label CI failed on Jul 5, 2025


maflcko DrahtBot

Labels
Tests


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-07-07 21:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me