util::Join
. To minimize unnecessary container allocations and simplify implementations, the first commit slightly refactors util::Join
so it can subsequently be used with range adaptors.
util::Join
. To minimize unnecessary container allocations and simplify implementations, the first commit slightly refactors util::Join
so it can subsequently be used with range adaptors.
By using a forwarding reference for `container`, the function can
be used with range adaptors that produce views that are not iterable
when const.
As a map, we can use views and util::Join on it to avoid duplicating
logic.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32942.
See the guideline for information on the review process.
Type | Reviewers |
---|---|
ACK | w0xlt |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Use Join where we manually concatenated before, or use ranges to
simplify the code.
🚧 At least one of the CI tasks failed.
Task tidy
: https://github.com/bitcoin/bitcoin/runs/45741536315
LLM reason (✨ experimental): clang-tidy detected errors related to recursive call chains, causing the CI to fail.
Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:
Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.
A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.
An intermittent issue.
Leave a comment here, if you need help tracking down a confusing failure.